RESOLVED FIXED Bug 97471
Web Inspector: Cookie info in Network Resources Cookies tab shows "Invalid Date" 
https://bugs.webkit.org/show_bug.cgi?id=97471
Summary Web Inspector: Cookie info in Network Resources Cookies tab shows "Invalid Date"
otcheung
Reported 2012-09-24 11:39:32 PDT
Cookietable.js is trying to create a new date object using another date object returned from CookieParser's cookie.expires method. This causes an "Invalid Date" error to show up when we view the cookie table under network resources.
Attachments
Patch (3.28 KB, patch)
2012-09-24 11:45 PDT, otcheung 		no flags
DetailsFormatted DiffDiff
Patch (19.62 KB, patch)
2012-11-01 07:11 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (19.64 KB, patch)
2012-11-01 09:17 PDT, Vsevolod Vlasov 		pfeldman: review+
pfeldman: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
otcheung
Comment 1 2012-09-24 11:45:21 PDT
Created attachment 165417 [details] Patch
WebKit Review Bot
Comment 2 2012-09-25 07:06:50 PDT
Comment on attachment 165417 [details] Patch Clearing flags on attachment: 165417 Committed r129502: <http://trac.webkit.org/changeset/129502>
WebKit Review Bot
Comment 3 2012-09-25 07:06:53 PDT
All reviewed patches have been landed. Closing bug.
Yury Semikhatsky
Comment 4 2012-09-26 06:16:56 PDT
Committed r129628: <http://trac.webkit.org/changeset/129628>
Yury Semikhatsky
Comment 5 2012-09-26 06:19:17 PDT
Reopening since the changed was rolled out in http://trac.webkit.org/changeset/129628 as it caused an exception in WebInspector.CookiesTable._createGridNode: Uncaught TypeError: Property 'expires' of object #<Object> is not a function CookiesTable.js:205 WebInspector.CookiesTable._createGridNode CookiesTable.js:205 WebInspector.CookiesTable._populateNode CookiesTable.js:138 WebInspector.CookiesTable._rebuildTable CookiesTable.js:121 WebInspector.CookiesTable.setCookies CookiesTable.js:92 WebInspector.CookieItemsView._updateWithCookies CookieItemsView.js:93 mycallback CookieItemsView.js:216 InspectorBackendClass.dispatch InspectorBackend.js:186 cookie object in the failing method comes from protocol and doesn't have 'expires' method.
otcheung
Comment 6 2012-09-26 08:29:01 PDT
Yury, what site did you visit to reproduce this issue?
Vsevolod Vlasov
Comment 7 2012-11-01 06:55:10 PDT
(In reply to comment #6) > Yury, what site did you visit to reproduce this issue? This was actually not the particular site issue but the problem with the presentation of cookies in the resources panel. The reason was that the cookies that are loaded via protocol form back-end are stored in different format and this ambiguity causes weird behavior. I am gonna reuse this bug to upload a complex patch (partly based on yours) that fixes overall problem.
Vsevolod Vlasov
Comment 8 2012-11-01 07:11:51 PDT
Created attachment 171838 [details] Patch
Vsevolod Vlasov
Comment 9 2012-11-01 09:17:40 PDT
Created attachment 171870 [details] Patch
Pavel Feldman
Comment 10 2012-11-01 09:36:19 PDT
Comment on attachment 171870 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171870&action=review > Source/WebCore/inspector/front-end/CookieParser.js:259 > + get expires() Please always use functions.
Vsevolod Vlasov
Comment 11 2012-11-02 01:53:25 PDT
Committed r133273: <http://trac.webkit.org/changeset/133273>
Note You need to log in before you can comment on or make changes to this bug.