RESOLVED FIXED Bug 97462
Web Inspector: [TextEditor] fix tab unindent selection restore 
https://bugs.webkit.org/show_bug.cgi?id=97462
Summary Web Inspector: [TextEditor] fix tab unindent selection restore
Andrey Adaikin
Reported 2012-09-24 09:46:28 PDT
Selection would be wrongly restored on tab unindent in the following example: " var a = 1; var" b = 2; (where selection is marked by quotes) which will become: "var a = 1; v"ar b = 2; while should be: "var a = 1; var" b = 2; Patch to follow.
Attachments
Patch (1.79 KB, patch)
2012-09-24 09:48 PDT, Andrey Adaikin 		no flags
DetailsFormatted DiffDiff
Patch (3.94 KB, patch)
2012-09-25 03:21 PDT, Andrey Adaikin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrey Adaikin
Comment 1 2012-09-24 09:48:54 PDT
Created attachment 165402 [details] Patch
Pavel Feldman
Comment 2 2012-09-24 09:54:51 PDT
Comment on attachment 165402 [details] Patch A test?
Andrey Adaikin
Comment 3 2012-09-24 09:58:28 PDT
@Nikita, have you written any test on the indent/unindent feature?
Andrey Adaikin
Comment 5 2012-09-24 10:05:38 PDT
Thanks! Will update the patch with a test.
Andrey Adaikin
Comment 6 2012-09-25 03:21:08 PDT
Created attachment 165569 [details] Patch
WebKit Review Bot
Comment 7 2012-09-26 02:08:36 PDT
Comment on attachment 165569 [details] Patch Clearing flags on attachment: 165569 Committed r129613: <http://trac.webkit.org/changeset/129613>
WebKit Review Bot
Comment 8 2012-09-26 02:08:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.