Bug 97460 – [GTK] Add Select All method to WebKit2 GTK+ API

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Simon Pena]

[GTK] Add Select All method to WebKit2 GTK+ API

[Simon Pena]

Created attachment 165400 [details]
Patch

[Simon Pena]

Updating component and adding Carlos to CC.

Carlos, I'm not sure if the unit test is a bit redundat right now, checking the same both when it's editable or not. What do you think? Do you think I should be testing anything else?

[WebKit Review Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Martin Robinson]

Comment on attachment 165400 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165400&action=review

Nice work. The tests you have written are more than adequate, in my opinion. I just have a few minor nits. Do you mind just uploading a new patch and then I can commit it for you.

> Source/WebKit2/UIProcess/API/gtk/tests/TestWebViewEditor.cpp:59
> +    void executeEditingCommand(const char* command)
> +    {
> +        webkit_web_view_execute_editing_command(m_webView, command);
> +    }
> +

Since this method just does one thing, it probably makes a bit more sense just do call webkit_web_view_execute_editing_command from the test. It makes it a bit more clear what API you are actually testing there.

> Source/WebKit2/UIProcess/API/gtk/tests/TestWebViewEditor.cpp:157
> +    // Initially only the subspan is selected

Just a minor nit here. Comments in WebKit should have a period at the end.

[Simon Pena]

Created attachment 165414 [details]
Patch

[Simon Pena]

(In reply to comment #5)
> Created an attachment (id=165414) [details]
> Patch

Addressing Martin's comments here

[WebKit Review Bot]

Comment on attachment 165414 [details]
Patch

Clearing flags on attachment: 165414

Committed r129399: <http://trac.webkit.org/changeset/129399>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.