Bug 97453 - Web Inspector: ResourceScriptMapping should no steal scripts from other mappings.
Summary: Web Inspector: ResourceScriptMapping should no steal scripts from other mappi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-24 07:14 PDT by Vsevolod Vlasov
Modified: 2012-09-25 03:58 PDT (History)
11 users (show)

See Also:

Attachments
Patch (10.62 KB, patch)
2012-09-24 07:17 PDT, Vsevolod Vlasov 		no flags Details | Formatted Diff | Diff
Patch (9.51 KB, patch)
2012-09-25 00:32 PDT, Vsevolod Vlasov 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-09-24 07:14:45 PDT 
Patch to follow.
Comment 1 Vsevolod Vlasov 2012-09-24 07:17:09 PDT 
Created attachment 165376 [details]
Patch
Comment 2 Pavel Feldman 2012-09-24 09:43:00 PDT 
Comment on attachment 165376 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165376&action=review

> Source/WebCore/inspector/front-end/Script.js:186
> +        return this._sourceMapping;

I would rather store mapping's scripts in its instance.
Comment 3 Vsevolod Vlasov 2012-09-25 00:32:15 PDT 
Created attachment 165540 [details]
Patch
Comment 4 Pavel Feldman 2012-09-25 02:27:13 PDT 
Comment on attachment 165540 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165540&action=review

> Source/WebCore/inspector/front-end/ResourceScriptMapping.js:83
> +        this._scripts.push(script);

I don't think you want anonymous scripts here.
Comment 5 Vsevolod Vlasov 2012-09-25 03:58:37 PDT 
Committed r129485: <http://trac.webkit.org/changeset/129485>