WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
97453
Web Inspector: ResourceScriptMapping should no steal scripts from other mappings.
https://bugs.webkit.org/show_bug.cgi?id=97453
Summary
Web Inspector: ResourceScriptMapping should no steal scripts from other mappi...
Vsevolod Vlasov
Reported
2012-09-24 07:14:45 PDT
Patch to follow.
Attachments
Patch
(10.62 KB, patch)
2012-09-24 07:17 PDT
,
Vsevolod Vlasov
no flags
Details
Formatted Diff
Diff
Patch
(9.51 KB, patch)
2012-09-25 00:32 PDT
,
Vsevolod Vlasov
pfeldman
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1
2012-09-24 07:17:09 PDT
Created
attachment 165376
[details]
Patch
Pavel Feldman
Comment 2
2012-09-24 09:43:00 PDT
Comment on
attachment 165376
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=165376&action=review
> Source/WebCore/inspector/front-end/Script.js:186 > + return this._sourceMapping;
I would rather store mapping's scripts in its instance.
Vsevolod Vlasov
Comment 3
2012-09-25 00:32:15 PDT
Created
attachment 165540
[details]
Patch
Pavel Feldman
Comment 4
2012-09-25 02:27:13 PDT
Comment on
attachment 165540
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=165540&action=review
> Source/WebCore/inspector/front-end/ResourceScriptMapping.js:83 > + this._scripts.push(script);
I don't think you want anonymous scripts here.
Vsevolod Vlasov
Comment 5
2012-09-25 03:58:37 PDT
Committed
r129485
: <
http://trac.webkit.org/changeset/129485
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug