WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 97447
sizeof(CSSRule) compile assertion failure
https://bugs.webkit.org/show_bug.cgi?id=97447
Summary
sizeof(CSSRule) compile assertion failure
Jonathan Liu
Reported
2012-09-24 05:39:06 PDT
COMPILE_ASSERT(sizeof(CSSRule) == sizeof(SameSizeAsCSSRule), CSSRule_should_stay_small) fails when building with MinGW-w64 GCC 4.7.2. It previously compiled successfully with MinGW-w64 GCC 4.6.3. The problem seems to be a change in the default behavior when padding bitfields. MinGW GCC 4.7.x uses -mms-bitfields by default while MinGW GCC 4.6.x doesn't. Since the underlying type is unsigned, it pads to 32-bit when it should really be padding to 8-bit.
Attachments
Patch.
(1.96 KB, patch)
2012-09-24 05:43 PDT
,
Jonathan Liu
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jonathan Liu
Comment 1
2012-09-24 05:43:45 PDT
Created
attachment 165359
[details]
Patch.
WebKit Review Bot
Comment 2
2012-09-24 07:39:58 PDT
Comment on
attachment 165359
[details]
Patch. Clearing flags on attachment: 165359 Committed
r129365
: <
http://trac.webkit.org/changeset/129365
>
WebKit Review Bot
Comment 3
2012-09-24 07:40:01 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug