Bug 97442 - Web Inspector: [TextEditor] conditional breakpoint popup not showing up the first time
Summary: Web Inspector: [TextEditor] conditional breakpoint popup not showing up the f...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Adaikin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-24 02:56 PDT by Andrey Adaikin
Modified: 2012-09-24 09:36 PDT (History)
11 users (show)

See Also:


Attachments
Patch (6.70 KB, patch)
2012-09-24 03:04 PDT, Andrey Adaikin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Adaikin 2012-09-24 02:56:26 PDT
The conditional breakpoint popup may not show up the first time we click on the gutter.
Also the popup will close itself on any mouse click event, even if it's targeted to the input box itself.

Example to repro:
- goto http://learningwebgl.com/lessons/lesson05/index.html
- open Source panel, select the file glMatrix-0.9.5.min.js
- mouse right click on the gutter on line 25 and choose "Add Conditional Breakpoint..."
- observe the popup opens and closes immediately
- do the same action on line 25 to edit the breakpoint
- now the popup should not close
- mouse click on the input box to observe the popup closing

Patch to follow.
Comment 1 Andrey Adaikin 2012-09-24 03:04:27 PDT
Created attachment 165339 [details]
Patch
Comment 2 WebKit Review Bot 2012-09-24 09:36:08 PDT
Comment on attachment 165339 [details]
Patch

Clearing flags on attachment: 165339

Committed r129381: <http://trac.webkit.org/changeset/129381>
Comment 3 WebKit Review Bot 2012-09-24 09:36:12 PDT
All reviewed patches have been landed.  Closing bug.