Bug 97431 – [EFL][WK2] Add callback functions for WKPageFindClient

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Jinwoo Song]

Add didFailToFindString() and didCountStringMatches() for WKPageFindClient's callback functions.

[Jinwoo Song]

Created attachment 165321 [details]
patch

[Chris Dumez]

Comment on attachment 165321 [details]
patch

Can we unit test this?

[Jinwoo Song]

(In reply to comment #2)
> (From update of attachment 165321 [details])
> Can we unit test this?

Sure, we can make a unit test. I'll add the unit test and upload a new patch.

[Gyuyoung Kim]

Comment on attachment 165321 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165321&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view_find_client.cpp:42
> +static void didFailToFindString(WKPageRef, WKStringRef /*string*/, const void* clientInfo)

It looks we can remove /*string*/. string doesn't represent anything.

> Source/WebKit2/UIProcess/API/efl/ewk_view_find_client.cpp:47
> +static void didCountStringMatches(WKPageRef, WKStringRef /*string*/, unsigned matchCount, const void* clientInfo)

ditto.

[Jinwoo Song]

(In reply to comment #4)
> (From update of attachment 165321 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=165321&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view_find_client.cpp:42
> > +static void didFailToFindString(WKPageRef, WKStringRef /*string*/, const void* clientInfo)
> 
> It looks we can remove /*string*/. string doesn't represent anything.
> 
Absolutely right!
> > Source/WebKit2/UIProcess/API/efl/ewk_view_find_client.cpp:47
> > +static void didCountStringMatches(WKPageRef, WKStringRef /*string*/, unsigned matchCount, const void* clientInfo)
> 
> ditto.

[Jinwoo Song]

Created attachment 165719 [details]
Patch

[Jinwoo Song]

The unit test for didFindString() and didFailToFindString() have beend added. But the  unit test for didCountStringMatches() needs 
a API which wraps the WKPageCountStringMatches but it is not exists yet. So I'll make that API and unit test in another patch.

[Chris Dumez]

Comment on attachment 165719 [details]
Patch

Looks sane.

[Laszlo Gombos]

Comment on attachment 165719 [details]
Patch

lgtm, r=me.

[WebKit Review Bot]

Comment on attachment 165719 [details]
Patch

Rejecting attachment 165719 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[Gyuyoung Kim]

Comment on attachment 165719 [details]
Patch

Clear cq+ because Gombos reviews has problem.

[Laszlo Gombos]

Comment on attachment 165719 [details]
Patch

r=me

[WebKit Review Bot]

Comment on attachment 165719 [details]
Patch

Clearing flags on attachment: 165719

Committed r129758: <http://trac.webkit.org/changeset/129758>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.