Bug 97416 - PutScopedVar should not be marked as clobbering the world
Summary: PutScopedVar should not be marked as clobbering the world
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-23 17:08 PDT by Geoffrey Garen
Modified: 2012-09-23 20:47 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.38 KB, patch)
2012-09-23 17:08 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2012-09-23 17:08:00 PDT 
PutScopedVar should not be marked as clobbering the world
Comment 1 Geoffrey Garen 2012-09-23 17:08:36 PDT 
Created attachment 165297 [details]
Patch
Comment 2 Filip Pizlo 2012-09-23 17:14:07 PDT 
Comment on attachment 165297 [details]
Patch

I think you've already covered your bases, but before landing I would go through the cases in CSE one more time and make sure that nothing has slipped by.  In your case, you're probably fine since we don't inline PutScopedVar, and we never have PutScopedVar on *this frame's* locals, and I don't think we do any CSE on resolve's.
Comment 3 Geoffrey Garen 2012-09-23 20:45:54 PDT 
> we don't inline PutScopedVar

Yeah.

> and we never have PutScopedVar on *this frame's* locals

Yup. (Or, when we do, we use get/put_scoped_var exclusively, and not local variable references.)

> and I don't think we do any CSE on resolve's.

Also true.
Comment 4 Geoffrey Garen 2012-09-23 20:47:20 PDT 
Comment on attachment 165297 [details]
Patch

Clearing flags on attachment: 165297

Committed r129325: <http://trac.webkit.org/changeset/129325>
Comment 5 Geoffrey Garen 2012-09-23 20:47:22 PDT 
All reviewed patches have been landed.  Closing bug.