Bug 97400 - Implement OES_element_index_uint / WEBKIT_OES_element_index_uint
Summary: Implement OES_element_index_uint / WEBKIT_OES_element_index_uint
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 420+
Hardware: All All
: P2 Enhancement
Assignee: Brandon Jones
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-22 15:54 PDT by rmnoon
Modified: 2012-10-18 11:18 PDT (History)
14 users (show)

See Also:


Attachments
Patch (58.83 KB, patch)
2012-10-12 15:45 PDT, Brandon Jones
no flags Details | Formatted Diff | Diff
Patch (58.84 KB, patch)
2012-10-12 16:24 PDT, Brandon Jones
no flags Details | Formatted Diff | Diff
Patch (60.37 KB, patch)
2012-10-15 11:07 PDT, Brandon Jones
no flags Details | Formatted Diff | Diff
Patch (60.37 KB, patch)
2012-10-16 10:59 PDT, Brandon Jones
no flags Details | Formatted Diff | Diff
Patch (60.35 KB, patch)
2012-10-18 09:59 PDT, Brandon Jones
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description rmnoon 2012-09-22 15:54:14 PDT
Out of the box, OpenGL ES 2 lacks the ability to use index buffers to index into VBOs with more than 2^16 elements (see http://www.khronos.org/opengles/sdk/docs/man/xhtml/glDrawElements.xml).  The extension OES_element_index_uint adds support for using unsigned integers, thereby supporting VBOs with 2^32 elements.  This is an important extension and is supported on desktop-class hardware and was added to iOS 5.

The WebGL spec is here:
http://www.khronos.org/registry/webgl/extensions/OES_element_index_uint/

The specification has been upgraded to Draft status, and thus may now be implemented by browsers under vendor-specific names.  The name for this extension in WebKit is WEBKIT_OES_element_index_uint.
Comment 1 Brandon Jones 2012-10-12 15:45:53 PDT
Created attachment 168500 [details]
Patch
Comment 2 Brandon Jones 2012-10-12 16:24:57 PDT
Created attachment 168508 [details]
Patch
Comment 3 Build Bot 2012-10-12 19:58:08 PDT
Comment on attachment 168508 [details]
Patch

Attachment 168508 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14288125

New failing tests:
fast/canvas/webgl/oes-element-index-uint.html
Comment 4 WebKit Review Bot 2012-10-13 02:38:46 PDT
Comment on attachment 168508 [details]
Patch

Attachment 168508 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14286171

New failing tests:
platform/chromium/virtual/gpu/fast/canvas/webgl/oes-element-index-uint.html
fast/canvas/webgl/oes-element-index-uint.html
Comment 5 Brandon Jones 2012-10-15 11:07:31 PDT
Created attachment 168742 [details]
Patch
Comment 6 Brandon Jones 2012-10-16 10:59:35 PDT
Created attachment 168976 [details]
Patch
Comment 7 Brandon Jones 2012-10-18 09:59:59 PDT
Created attachment 169429 [details]
Patch
Comment 8 Kenneth Russell 2012-10-18 10:54:24 PDT
Comment on attachment 169429 [details]
Patch

Looks good. Nice work on the tests in particular. We should consider refactoring them as was done for conformance/textures/tex-image-and-sub-image-2d-with-canvas.html and related tests in order to reduce duplication. r=me
Comment 9 WebKit Review Bot 2012-10-18 11:18:42 PDT
Comment on attachment 169429 [details]
Patch

Clearing flags on attachment: 169429

Committed r131780: <http://trac.webkit.org/changeset/131780>
Comment 10 WebKit Review Bot 2012-10-18 11:18:48 PDT
All reviewed patches have been landed.  Closing bug.