Bug 97387 - [CSSRegions]Add test for accelerating compositing of elements in RenderFlowThread
Summary: [CSSRegions]Add test for accelerating compositing of elements in RenderFlowTh...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mihnea Ovidenie
URL:
Keywords:
: 90770 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-09-21 23:40 PDT by Mihnea Ovidenie
Modified: 2012-09-22 04:16 PDT (History)
4 users (show)

See Also:


Attachments
Patch (9.51 KB, patch)
2012-09-22 00:08 PDT, Mihnea Ovidenie
no flags Details | Formatted Diff | Diff
Patch 2 (11.11 KB, patch)
2012-09-22 01:55 PDT, Mihnea Ovidenie
no flags Details | Formatted Diff | Diff
Patch 3 (11.29 KB, patch)
2012-09-22 02:43 PDT, Mihnea Ovidenie
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mihnea Ovidenie 2012-09-21 23:40:59 PDT
At this moment, we disable accelerated compositing for elements in a RenderFlowThread as it doesn't work properly. The WebKit Bug (https://bugs.webkit.org/show_bug.cgi?id=84900) is tracking the implementation. Add a separate test for this issue in LayoutTest/compositing and remove the testing code for accelerated compositing from LayoutTest/fast/regions/webkit-flow-renderer-layer.html.
Comment 1 Mihnea Ovidenie 2012-09-22 00:08:10 PDT
Created attachment 165251 [details]
Patch
Comment 2 Mihnea Ovidenie 2012-09-22 01:55:29 PDT
Created attachment 165254 [details]
Patch 2

Rewrite tests to make them more obvious when they pass/fail.
Comment 3 Alexandru Chiculita 2012-09-22 02:02:42 PDT
Comment on attachment 165254 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=165254&action=review

[Informal review] Looks good to me. Some minor comments.

> LayoutTests/compositing/regions/webkit-flow-renderer-layer-compositing.html:9
> +        width: 50px; height: 50px; background-color: green;

Nit: Some properties use their own row, others don't. I would update these to follow the same style.

> LayoutTests/compositing/regions/webkit-flow-renderer-layer-compositing.html:15
> +<p>Test for <a href="https://bugs.webkit.org/show_bug.cgi?id=84900"> [CSS Regions] Enable accelerated layers on elements inside a RenderFlowThread</a>.</p>

Add a comment on the 84900 bug to remember that you've added this test.
Comment 4 Mihnea Ovidenie 2012-09-22 02:43:00 PDT
Created attachment 165255 [details]
Patch 3

Taking review into account.
Comment 5 WebKit Review Bot 2012-09-22 03:31:29 PDT
Comment on attachment 165255 [details]
Patch 3

Clearing flags on attachment: 165255

Committed r129304: <http://trac.webkit.org/changeset/129304>
Comment 6 WebKit Review Bot 2012-09-22 03:31:33 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Mihnea Ovidenie 2012-09-22 04:16:10 PDT
*** Bug 90770 has been marked as a duplicate of this bug. ***