Bug 97387 – [CSSRegions]Add test for accelerating compositing of elements in RenderFlowThread

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Mihnea Ovidenie]

At this moment, we disable accelerated compositing for elements in a RenderFlowThread as it doesn't work properly. The WebKit Bug (https://bugs.webkit.org/show_bug.cgi?id=84900) is tracking the implementation. Add a separate test for this issue in LayoutTest/compositing and remove the testing code for accelerated compositing from LayoutTest/fast/regions/webkit-flow-renderer-layer.html.

[Mihnea Ovidenie]

Created attachment 165251 [details]
Patch

[Mihnea Ovidenie]

Created attachment 165254 [details]
Patch 2

Rewrite tests to make them more obvious when they pass/fail.

[Alexandru Chiculita]

Comment on attachment 165254 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=165254&action=review

[Informal review] Looks good to me. Some minor comments.

> LayoutTests/compositing/regions/webkit-flow-renderer-layer-compositing.html:9
> +        width: 50px; height: 50px; background-color: green;

Nit: Some properties use their own row, others don't. I would update these to follow the same style.

> LayoutTests/compositing/regions/webkit-flow-renderer-layer-compositing.html:15
> +<p>Test for <a href="https://bugs.webkit.org/show_bug.cgi?id=84900"> [CSS Regions] Enable accelerated layers on elements inside a RenderFlowThread</a>.</p>

Add a comment on the 84900 bug to remember that you've added this test.

[Mihnea Ovidenie]

Created attachment 165255 [details]
Patch 3

Taking review into account.

[WebKit Review Bot]

Comment on attachment 165255 [details]
Patch 3

Clearing flags on attachment: 165255

Committed r129304: <http://trac.webkit.org/changeset/129304>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Mihnea Ovidenie]

*** Bug 90770 has been marked as a duplicate of this bug. ***