Bug 97386 – Fix Geolocation error reporting in the test support

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Benjamin Poulain]

The method setMockGeolocationError() does not make much sense for testing because 2 of the 3 code are supposed to be internal.

This is Part 1, fix the upper layer. There may be a Part 2 if GeolocationController can also be cleaned without breaking any port.

[Benjamin Poulain]

Created attachment 165244 [details]
Patch

[WebKit Review Bot]

Comment on attachment 165244 [details]
Patch

Attachment 165244 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13950910

[Early Warning System Bot]

Comment on attachment 165244 [details]
Patch

Attachment 165244 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13981378

[Early Warning System Bot]

Comment on attachment 165244 [details]
Patch

Attachment 165244 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13954888

[Peter Beverloo (cr-android ews)]

Comment on attachment 165244 [details]
Patch

Attachment 165244 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13948953

[Benjamin Poulain]

Created attachment 165246 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Gyuyoung Kim]

Comment on attachment 165246 [details]
Patch

Attachment 165246 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13935864

[WebKit Review Bot]

Comment on attachment 165246 [details]
Patch

Attachment 165246 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13916919

[Peter Beverloo (cr-android ews)]

Comment on attachment 165246 [details]
Patch

Attachment 165246 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13975667

[Benjamin Poulain]

Created attachment 165247 [details]
Patch

[WebKit Review Bot]

Comment on attachment 165247 [details]
Patch

Attachment 165247 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13948974

[Peter Beverloo (cr-android ews)]

Comment on attachment 165247 [details]
Patch

Attachment 165247 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13954902

[Benjamin Poulain]

Created attachment 165249 [details]
Patch

[WebKit Review Bot]

Comment on attachment 165249 [details]
Patch

Attachment 165249 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13956933

[Benjamin Poulain]

Created attachment 165250 [details]
Patch

[Benjamin Poulain]

Chromium is a PITA here because there is no clear API, everything is exposed :(

Next I'll get rid of GeolocationController::errorOccurred(), Geolocation::setError() and GeolocationError. I may have to #ifdef everything for Chromium.

Adam, this patch modifies WebKit/Chromium/public. Is that Okay?

[WebKit Review Bot]

Comment on attachment 165250 [details]
Patch

Attachment 165250 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13958905

New failing tests:
fast/dom/Geolocation/reentrant-error.html
fast/dom/Geolocation/error.html
fast/dom/Geolocation/error-clear-watch.html
fast/dom/Geolocation/watch.html
WebFilterOperationsTest.saveAndRestore
fast/dom/Geolocation/maximum-age.html

[Adam Barth]

Comment on attachment 165250 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165250&action=review

> Source/WebKit/chromium/public/WebGeolocationClientMock.h:52
> -    WEBKIT_EXPORT void setError(int errorCode, const WebString& message);
> +    WEBKIT_EXPORT void setMockGeolocationPositionUnavailableError(const WebString& message);

API change LGTM

[Benjamin Poulain]

Created attachment 165427 [details]
Patch

[WebKit Review Bot]

Comment on attachment 165427 [details]
Patch

Attachment 165427 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14006205

[Benjamin Poulain]

Created attachment 165440 [details]
Patch

[Sam Weinig]

Comment on attachment 165440 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165440&action=review

r=me

> Source/WebKit/chromium/public/WebGeolocationClientMock.h:52
> -    WEBKIT_EXPORT void setError(int errorCode, const WebString& message);
> +    WEBKIT_EXPORT void setPositionUnavailableError(const WebString& message);

I am not sure if you are supposed to change this.

[Adam Barth]

(In reply to comment #23)
> (From update of attachment 165440 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=165440&action=review
> 
> r=me
> 
> > Source/WebKit/chromium/public/WebGeolocationClientMock.h:52
> > -    WEBKIT_EXPORT void setError(int errorCode, const WebString& message);
> > +    WEBKIT_EXPORT void setPositionUnavailableError(const WebString& message);
> 
> I am not sure if you are supposed to change this.

See https://bugs.webkit.org/show_bug.cgi?id=97386#c19

[Benjamin Poulain]

Comment on attachment 165440 [details]
Patch

Clearing flags on attachment: 165440

Committed r129444: <http://trac.webkit.org/changeset/129444>

[Benjamin Poulain]

All reviewed patches have been landed.  Closing bug.