Bug 97380 – nrwt: don't require additional-platform-directory to be an abspath or live under LayoutTests

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dirk Pranke]

nrwt: don't require additional-platform-directory to be an abspath or live under LayoutTests

[Dirk Pranke]

Created attachment 165231 [details]
Patch

[Dirk Pranke]

Committed r129285: <http://trac.webkit.org/changeset/129285>

[Ryosuke Niwa]

Comment on attachment 165231 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165231&action=review

> Tools/Scripts/webkitpy/layout_tests/port/base.py:802
> +        if filename.startswith(self.perf_tests_dir()):
> +            return self.host.filesystem.relpath(filename, self.perf_tests_dir())
> +        else:
> +            return self.filesystem.abspath(filename)

This doesn't work for performance tests because this relative path is used elsewhere as the test name after split by /.

[Dirk Pranke]

(In reply to comment #3)
> (From update of attachment 165231 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=165231&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/port/base.py:802
> > +        if filename.startswith(self.perf_tests_dir()):
> > +            return self.host.filesystem.relpath(filename, self.perf_tests_dir())
> > +        else:
> > +            return self.filesystem.abspath(filename)
> 
> This doesn't work for performance tests because this relative path is used elsewhere as the test name after split by /.

I don't follow you ... can you explain further?

[Ryosuke Niwa]

(In reply to comment #4)
> (In reply to comment #3)
> >
> > This doesn't work for performance tests because this relative path is used elsewhere as the test name after split by /.
> 
> I don't follow you ... can you explain further?

All test names (this is human-readable name re-formatted by the script), etc... are computed from this relative test name so the rest of run-perf-tests will just blow up if you use an absolute path.

I got rid of this function in https://bugs.webkit.org/show_bug.cgi?id=105219.