Bug 97379 - Update SVGFontData for 8 bit TextRun changes
Summary: Update SVGFontData for 8 bit TextRun changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-21 16:29 PDT by Michael Saboff
Modified: 2022-02-27 23:32 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.05 KB, patch)
2012-09-23 22:08 PDT, Michael Saboff
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2012-09-21 16:29:58 PDT
Make SVGFontData aware of 8 bit changes to TextRun.
Comment 1 Michael Saboff 2012-09-23 22:08:14 PDT
Created attachment 165310 [details]
Patch
Comment 2 Sam Weinig 2012-09-25 00:54:18 PDT
Comment on attachment 165310 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165310&action=review

> Source/WebCore/svg/SVGFontData.cpp:148
>          remainingTextInRun = createStringWithMirroredCharacters(remainingTextInRun.characters(), remainingTextInRun.length());

Is this line also 8 / 16 bit aware?
Comment 3 Michael Saboff 2012-09-25 09:43:28 PDT
(In reply to comment #2)
> (From update of attachment 165310 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=165310&action=review
> 
> > Source/WebCore/svg/SVGFontData.cpp:148
> >          remainingTextInRun = createStringWithMirroredCharacters(remainingTextInRun.characters(), remainingTextInRun.length());
> 
> Is this line also 8 / 16 bit aware?

Yes, characters() up converts 8 bit data if necessary.
Comment 4 Geoffrey Garen 2012-09-25 23:32:53 PDT
Comment on attachment 165310 [details]
Patch

r=me
Comment 5 Michael Saboff 2012-09-26 10:43:42 PDT
Committed r129668: <http://trac.webkit.org/changeset/129668>