RESOLVED FIXED 97378
Update ComplexTextController for 8 bit TextRun changes 
https://bugs.webkit.org/show_bug.cgi?id=97378
Summary Update ComplexTextController for 8 bit TextRun changes
Michael Saboff
Reported 2012-09-21 16:28:45 PDT
Update ComplexTextController so that it works with 8 bit TextRun's. It will need to up convert an 8 bit TextRun to 16 bit data unless we go through some major refactoring of the complex path.
Attachments
Patch (5.62 KB, patch)
2012-09-21 16:55 PDT, Michael Saboff 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2012-09-21 16:55:40 PDT
Created attachment 165227 [details] Patch
Geoffrey Garen
Comment 2 2012-09-22 23:30:59 PDT
Comment on attachment 165227 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165227&action=review > Source/WebCore/platform/graphics/mac/ComplexTextController.cpp:299 > + String stringFor8BitRun = String::make16BitFrom8BitSource(m_run.characters8(), m_run.length()); Why did you choose not to call m_run.characters() here?
Michael Saboff
Comment 3 2012-09-23 22:07:04 PDT
(In reply to comment #2) > (From update of attachment 165227 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=165227&action=review > > > Source/WebCore/platform/graphics/mac/ComplexTextController.cpp:299 > > + String stringFor8BitRun = String::make16BitFrom8BitSource(m_run.characters8(), m_run.length()); > > Why did you choose not to call m_run.characters() here? m_run is a TextRun and TextRun doesn't have a characters() method. TextRun stores data in a union of LChar* / UChar* pointers and not a String.
Geoffrey Garen
Comment 4 2012-09-25 23:32:11 PDT
Comment on attachment 165227 [details] Patch r=me
Michael Saboff
Comment 5 2012-09-26 10:26:01 PDT
Committed r129664: <http://trac.webkit.org/changeset/129664>
Note You need to log in before you can comment on or make changes to this bug.