Bug 97378 - Update ComplexTextController for 8 bit TextRun changes
Summary: Update ComplexTextController for 8 bit TextRun changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks: 99393
  Show dependency tree / graph
 
Reported: 2012-09-21 16:28 PDT by Michael Saboff
Modified: 2022-02-27 23:32 PST (History)
3 users (show)

See Also:

Attachments
Patch (5.62 KB, patch)
2012-09-21 16:55 PDT, Michael Saboff 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2012-09-21 16:28:45 PDT 
Update ComplexTextController so that it works with 8 bit TextRun's.  It will need to up convert an 8 bit TextRun to 16 bit data unless we go through some major refactoring of the complex path.
Comment 1 Michael Saboff 2012-09-21 16:55:40 PDT 
Created attachment 165227 [details]
Patch
Comment 2 Geoffrey Garen 2012-09-22 23:30:59 PDT 
Comment on attachment 165227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165227&action=review

> Source/WebCore/platform/graphics/mac/ComplexTextController.cpp:299
> +        String stringFor8BitRun = String::make16BitFrom8BitSource(m_run.characters8(), m_run.length());

Why did you choose not to call m_run.characters() here?
Comment 3 Michael Saboff 2012-09-23 22:07:04 PDT 
(In reply to comment #2)
> (From update of attachment 165227 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=165227&action=review
> 
> > Source/WebCore/platform/graphics/mac/ComplexTextController.cpp:299
> > +        String stringFor8BitRun = String::make16BitFrom8BitSource(m_run.characters8(), m_run.length());
> 
> Why did you choose not to call m_run.characters() here?

m_run is a TextRun and TextRun doesn't have a characters() method.  TextRun stores data in a union of LChar* / UChar* pointers and not a String.
Comment 4 Geoffrey Garen 2012-09-25 23:32:11 PDT 
Comment on attachment 165227 [details]
Patch

r=me
Comment 5 Michael Saboff 2012-09-26 10:26:01 PDT 
Committed r129664: <http://trac.webkit.org/changeset/129664>