Bug 97358 - Optimized closures that capture arguments
Summary: Optimized closures that capture arguments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-21 13:42 PDT by Geoffrey Garen
Modified: 2012-09-21 23:34 PDT (History)
1 user (show)

See Also:

Attachments
Patch (33.87 KB, patch)
2012-09-21 16:34 PDT, Geoffrey Garen 		oliver: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2012-09-21 13:42:37 PDT 
Optimized closures that capture arguments
Comment 1 Geoffrey Garen 2012-09-21 16:34:52 PDT 
Created attachment 165224 [details]
Patch
Comment 2 WebKit Review Bot 2012-09-21 16:36:50 PDT 
Attachment 165224 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/runtime/JSActivation.h:44:  The parameter name "globalData" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/ChangeLog:67:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 2 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2012-09-21 17:41:47 PDT 
Comment on attachment 165224 [details]
Patch

Attachment 165224 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13975570

New failing tests:
jquery/event.html
Comment 4 Build Bot 2012-09-21 18:43:56 PDT 
Comment on attachment 165224 [details]
Patch

Attachment 165224 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13954831

New failing tests:
jquery/event.html
Comment 5 Geoffrey Garen 2012-09-21 23:34:28 PDT 
Committed r129297: <http://trac.webkit.org/changeset/129297>