Bug 97353 - Split stylesheet related code out from Document
Summary: Split stylesheet related code out from Document
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-21 11:59 PDT by Antti Koivisto
Modified: 2012-09-24 15:14 PDT (History)
11 users (show)

See Also:

Attachments
patch (103.47 KB, patch)
2012-09-22 22:33 PDT, Antti Koivisto 		eric: review-
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
try to make it build (528.76 KB, patch)
2012-09-24 11:46 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
update to tot (528.66 KB, patch)
2012-09-24 12:03 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
another try (528.54 KB, patch)
2012-09-24 12:16 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
another rebase (528.91 KB, patch)
2012-09-24 13:57 PDT, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2012-09-21 11:59:00 PDT 
Document is big and unwieldy. The code related to tracking active stylesheets can be factored out.
Comment 1 Antti Koivisto 2012-09-22 22:33:57 PDT 
Created attachment 165278 [details]
patch
Comment 2 Early Warning System Bot 2012-09-22 22:55:08 PDT 
Comment on attachment 165278 [details]
patch

Attachment 165278 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13988234
Comment 3 Gyuyoung Kim 2012-09-22 22:56:45 PDT 
Comment on attachment 165278 [details]
patch

Attachment 165278 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13985280
Comment 4 Early Warning System Bot 2012-09-22 22:58:25 PDT 
Comment on attachment 165278 [details]
patch

Attachment 165278 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13993198
Comment 5 Build Bot 2012-09-22 23:05:29 PDT 
Comment on attachment 165278 [details]
patch

Attachment 165278 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13990197
Comment 6 WebKit Review Bot 2012-09-22 23:07:00 PDT 
Comment on attachment 165278 [details]
patch

Attachment 165278 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13986250
Comment 7 Build Bot 2012-09-22 23:18:48 PDT 
Comment on attachment 165278 [details]
patch

Attachment 165278 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13993200
Comment 8 Peter Beverloo (cr-android ews) 2012-09-22 23:31:42 PDT 
Comment on attachment 165278 [details]
patch

Attachment 165278 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13993202
Comment 9 Gyuyoung Kim 2012-09-22 23:44:05 PDT 
Comment on attachment 165278 [details]
patch

Attachment 165278 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13981669
Comment 10 Early Warning System Bot 2012-09-23 00:06:49 PDT 
Comment on attachment 165278 [details]
patch

Attachment 165278 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13986268
Comment 11 Andreas Kling 2012-09-23 07:58:51 PDT 
Comment on attachment 165278 [details]
patch

This is a fantastic cleanup. Obviously needs some build system love.

Mac EWS failure:
Undefined symbols for architecture x86_64:
  "__ZN7WebCore8Document18clearStyleResolverEv", referenced from:
      __ZN7WebCore28DocumentStyleSheetCollection23updateActiveStyleSheetsENS0_10UpdateFlagE in DocumentStyleSheetCollection.o

Need to remove inline keyword from Document::clearStyleResolver() implementation I suppose.
Comment 12 Eric Seidel (no email) 2012-09-23 08:51:02 PDT 
Huge fan!
Comment 13 Dimitri Glazkov (Google) 2012-09-23 08:55:23 PDT 
Kisses!
Comment 14 Eric Seidel (no email) 2012-09-23 21:09:14 PDT 
Comment on attachment 165278 [details]
patch

r- for making the bots mad.  I'm excited to see v2!
Comment 15 Antti Koivisto 2012-09-24 11:46:13 PDT 
Created attachment 165418 [details]
try to make it build 

- build files for non-mac platforms
- svn cp'd Document.cpp so we preserve the history for the moved functions
Comment 16 Antti Koivisto 2012-09-24 12:03:33 PDT 
Created attachment 165423 [details]
update to tot
Comment 17 Antti Koivisto 2012-09-24 12:16:22 PDT 
Created attachment 165426 [details]
another try
Comment 18 Antti Koivisto 2012-09-24 13:57:12 PDT 
Created attachment 165442 [details]
another rebase
Comment 19 Antti Koivisto 2012-09-24 15:14:45 PDT 
http://trac.webkit.org/changeset/129423