Bug 97348 – [BlackBerry] Really fix bug 95488 that user can get the authentication challenge dialog while the other tab has focus.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Lyon Chen]

Bug 95488 (https://bugs.webkit.org/show_bug.cgi?id=95488) is closed after its first patch is in. We need another patch to really fix the issue that pop up authentication challenge dialog when the page has no focus.

[Lyon Chen]

Created attachment 165157 [details]
patch for 97348

[Lyon Chen]

+Yong, Rob, Joe.

[WebKit Review Bot]

Attachment 165157 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebKit/blackberry/ChangeLog:10:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/WebKit/blackberry/ChangeLog:11:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/WebKit/blackberry/ChangeLog:13:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/WebCore/ChangeLog:12:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/WebCore/ChangeLog:13:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/WebCore/ChangeLog:14:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/WebCore/ChangeLog:17:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/WebCore/ChangeLog:20:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 8 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Lyon Chen]

Created attachment 165160 [details]
Fixing coding style errors in ChangeLog

[Joe Mason]

Comment on attachment 165160 [details]
Fixing coding style errors in ChangeLog

We already have deferLoading, you should use that instead of this new "freeze"

[Lyon Chen]

Created attachment 165180 [details]
Update to use deferLoading

[Joe Mason]

Comment on attachment 165180 [details]
Update to use deferLoading

lgtm

[WebKit Review Bot]

Comment on attachment 165180 [details]
Update to use deferLoading

Rejecting attachment 165180 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[WebKit Review Bot]

Comment on attachment 165180 [details]
Update to use deferLoading

Rejecting attachment 165180 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Review Bot]

Comment on attachment 165180 [details]
Update to use deferLoading

Clearing flags on attachment: 165180

Committed r129251: <http://trac.webkit.org/changeset/129251>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.