Bug 97342 - [BlackBerry] Media player won't resize for the following source when first source fail to load
Summary: [BlackBerry] Media player won't resize for the following source when first so...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Dong
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-21 08:48 PDT by Jonathan Dong
Modified: 2012-09-21 09:31 PDT (History)
10 users (show)

See Also:


Attachments
Patch (2.11 KB, patch)
2012-09-21 08:52 PDT, Jonathan Dong
no flags Details | Formatted Diff | Diff
Patch (2.10 KB, patch)
2012-09-21 08:55 PDT, Jonathan Dong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Dong 2012-09-21 08:48:46 PDT
RIM PR: 211662

simplified test case:
<html>
    <body>
        <video control>
            <source src="video-do-not-exist.mp4" />
            <source src="video-valid.mp4" />
        </video>
    </body>
</html>

the first source is an invalid url and the second is valid. This issue can also reproduce by test case media/video-size.html

The root cause is if we failed to load the first source, we will accidentally set the video renderer's width and height attributes, which will prevent the second source's intrinsic size if it gets loaded successfully.
Comment 1 Jonathan Dong 2012-09-21 08:52:32 PDT
Created attachment 165139 [details]
Patch
Comment 2 Jonathan Dong 2012-09-21 08:55:23 PDT
Created attachment 165141 [details]
Patch
Comment 3 WebKit Review Bot 2012-09-21 09:31:42 PDT
Comment on attachment 165141 [details]
Patch

Clearing flags on attachment: 165141

Committed r129235: <http://trac.webkit.org/changeset/129235>
Comment 4 WebKit Review Bot 2012-09-21 09:31:45 PDT
All reviewed patches have been landed.  Closing bug.