Bug 97327 - [Forms] We should remove DateTimeEditElement::valueAsDouble()
Summary: [Forms] We should remove DateTimeEditElement::valueAsDouble()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on: 97303
Blocks: 97299
  Show dependency treegraph
 
Reported: 2012-09-21 04:15 PDT by yosin
Modified: 2012-09-24 21:40 PDT (History)
1 user (show)

See Also:


Attachments
Patch 1 (9.63 KB, patch)
2012-09-24 20:55 PDT, yosin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-09-21 04:15:47 PDT
Nobody uses DateTimeEditElement::valueAsDouble().
We should remove DateTimeFieldElement::valueAsDouble() and DateTimeFieldElement::unitInMillisecond() too.
Comment 1 yosin 2012-09-24 20:55:42 PDT
Created attachment 165506 [details]
Patch 1
Comment 2 yosin 2012-09-24 20:56:58 PDT
Comment on attachment 165506 [details]
Patch 1

Could you review this patch?
Thanks in advance.
Comment 3 Kent Tamura 2012-09-24 21:31:58 PDT
Comment on attachment 165506 [details]
Patch 1

ok
Comment 4 yosin 2012-09-24 21:40:26 PDT
Comment on attachment 165506 [details]
Patch 1

Clearing flags on attachment: 165506

Committed r129455: <http://trac.webkit.org/changeset/129455>
Comment 5 yosin 2012-09-24 21:40:30 PDT
All reviewed patches have been landed.  Closing bug.