Bug 97323 – [GTK] [Webkit2] Add a setting to enable/disable css regions to WebKit2 GTK+ API

• Status: RESOLVED
• Resolution: INVALID
• Component: WebKitGTK

[Alejandro G. Castro]

It is an experimental feature and it is activated by default, browsers should be able to disable it.

[jaybhaskar]

do you want it to disable this feature at runtime

[Alejandro G. Castro]

Created attachment 165112 [details]
Proposed patch

[Alejandro G. Castro]

(In reply to comment #1)
> do you want it to disable this feature at runtime

The feature is built and activated by default and at least we have to be able to disable it in the browser when releasing, because Adobe people told us it is experimental and currently it has still a lot of issues:

https://bugs.webkit.org/buglist.cgi?query_format=advanced&short_desc_type=allwordssubstr&short_desc=regions&long_desc_type=substring&long_desc=&bug_file_loc_type=allwordssubstr&bug_file_loc=&keywords_type=allwords&keywords=&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&emailassigned_to1=1&emailtype1=substring&email1=&emailassigned_to2=1&emailreporter2=1&emailcc2=1&emailtype2=substring&email2=&bugidtype=include&bug_id=&chfieldfrom=&chfieldto=Now&chfieldvalue=&cmdtype=doit&order=Reuse+same+sort+as+last+time&field0-0-0=noop&type0-0-0=noop&value0-0-0=

Chromium is also releasing the code but disabling it by default.

[Martin Robinson]

Comment on attachment 165112 [details]
Proposed patch

Maybe it just makes sense to disable it manually for now and expose a way to turn it on and off via DRTSupport? I'm wondering whether, in the future, when the feature is stable it will be useful to turn it on and off.

[Alejandro G. Castro]

(In reply to comment #4)
> (From update of attachment 165112 [details])
> Maybe it just makes sense to disable it manually for now and expose a way to turn it on and off via DRTSupport? I'm wondering whether, in the future, when the feature is stable it will be useful to turn it on and off.

Yeah, I thought about it, because adding API that could be in the future deprecated at some point is not nice, patch seemed a good way to check other opinions. We also have some API like this in webkit1. Anyway after also talking to Dirk about it I think we can avoid this and basically turn it on in general when unstable and just turn it off for the stable releases if we feel it is too unstable for the moment. This is the only option if we want to avoid adding API for these features and testing them in the real browser.

If this sounds ok I can close this bug and change the patch for WebKit1 to enable the feature in the library.

[Martin Robinson]

You've definitely hit on my worry here. At some point CSS regions may become so stable that they won't be togglable. We'll have trouble because we'll still have the API. Your suggestions sounds good to me!

[Alejandro G. Castro]

Great, thanks for the comments.

[Eric Seidel (no email)]

Comment on attachment 165112 [details]
Proposed patch

Cleared review? from attachment 165112 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).