Bug 97321 – Web Inspector: Highlight multiple nodes in page

• Status: RESOLVED
• Resolution: INVALID
• Component: Web Inspector (Deprecated)

[Andrei Poenaru]

Modify the way elements are highlighted in the page in order to add a command to the protocol that takes a list of NodeIds and highlights them.

[Andrei Poenaru]

Created attachment 165124 [details]
A hack to get multiple highlighting

[Pavel Feldman]

Comment on attachment 165124 [details]
A hack to get multiple highlighting

View in context: https://bugs.webkit.org/attachment.cgi?id=165124&action=review

> Source/WebCore/inspector/Inspector.json:1814
> +                    { "name": "highlightConfig", "$ref": "HighlightConfig", "description": "A descriptor for the highlight apperance." }

I wonder if we want to have a config per node. I can imagine a list of nodes where there is a parent node that is only rendered as border and a list of child nodes that are rendered as boxes.

> Source/WebCore/inspector/InspectorController.cpp:82
> +    , m_overlays(InspectorOverlayCollection::create(page, inspectorClient))

You should only have one overlay, just make InspectorOverlay::highlightNode receive an array of nodes (and configs).

[Andrei Poenaru]

Created attachment 165338 [details]
Patch

[Build Bot]

Comment on attachment 165338 [details]
Patch

Attachment 165338 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14002333

[Gyuyoung Kim]

Comment on attachment 165338 [details]
Patch

Attachment 165338 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13997521

[Build Bot]

Comment on attachment 165338 [details]
Patch

Attachment 165338 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13984713

[Early Warning System Bot]

Comment on attachment 165338 [details]
Patch

Attachment 165338 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13986640

[Early Warning System Bot]

Comment on attachment 165338 [details]
Patch

Attachment 165338 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14006030

[kov's GTK+ EWS bot]

Comment on attachment 165338 [details]
Patch

Attachment 165338 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/13996620