RESOLVED FIXED 97314
[BlackBerry] Remove obsolete compositing surface code 
https://bugs.webkit.org/show_bug.cgi?id=97314
Summary [BlackBerry] Remove obsolete compositing surface code
Arvid Nilsson
Reported 2012-09-21 02:45:56 PDT
The removed code allowed rendering of sublayers to a separate offscreen surface. Now that we composite root layer and all sublayers to the window surface, this code is not needed anymore. In addition, we save some memory by not allocating the unused offscreen surface.
Attachments
Patch (26.20 KB, patch)
2012-09-21 02:56 PDT, Arvid Nilsson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Arvid Nilsson
Comment 1 2012-09-21 02:54:06 PDT
PR 208038
Arvid Nilsson
Comment 2 2012-09-21 02:56:16 PDT
Created attachment 165099 [details] Patch
Antonio Gomes
Comment 3 2012-09-21 05:20:26 PDT
Comment on attachment 165099 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165099&action=review > Source/WebKit/blackberry/Api/WebPage.cpp:-3669 > - if (m_pendingOrientation != -1) > - SurfacePool::globalSurfacePool()->notifyScreenRotated(); > - related?
Arvid Nilsson
Comment 4 2012-09-21 06:29:05 PDT
(In reply to comment #3) > (From update of attachment 165099 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=165099&action=review > > > Source/WebKit/blackberry/Api/WebPage.cpp:-3669 > > - if (m_pendingOrientation != -1) > > - SurfacePool::globalSurfacePool()->notifyScreenRotated(); > > - > > related? Yes, the only reason the surface pool needed to know about screen rotation, was to reallocate the compositing surface at the new size. So it's not needed any more.
WebKit Review Bot
Comment 5 2012-09-21 06:38:07 PDT
Comment on attachment 165099 [details] Patch Clearing flags on attachment: 165099 Committed r129222: <http://trac.webkit.org/changeset/129222>
WebKit Review Bot
Comment 6 2012-09-21 06:38:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.