Bug 97313 - [BlackBerry] Wrong seperator for viewport meta in Popup scripts
Summary: [BlackBerry] Wrong seperator for viewport meta in Popup scripts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Major
Assignee: Charles Wei
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-21 02:37 PDT by Charles Wei
Modified: 2012-09-21 07:59 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.78 KB, patch)
2012-09-21 03:01 PDT, Charles Wei
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Wei 2012-09-21 02:37:18 PDT
The valid seperator for viewport meta is ',' instead of ';'.  We are using the wrong seperator in PopupDialogBlackBerry.cpp
Comment 1 Charles Wei 2012-09-21 03:01:37 PDT
Created attachment 165101 [details]
Patch
Comment 2 Yong Li 2012-09-21 07:09:06 PDT
Comment on attachment 165101 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165101&action=review

> Source/WebKit/blackberry/ChangeLog:3
> +        Wrong seperator for viewport meta in Popup scripts

[BlackBerry] should be put there as other changes. it seems minor as the changelog is in webkit/blackberry anyway.
Comment 3 Charles Wei 2012-09-21 07:50:54 PDT
Comment on attachment 165101 [details]
Patch

Commit
Comment 4 WebKit Review Bot 2012-09-21 07:59:28 PDT
Comment on attachment 165101 [details]
Patch

Clearing flags on attachment: 165101

Committed r129228: <http://trac.webkit.org/changeset/129228>
Comment 5 WebKit Review Bot 2012-09-21 07:59:31 PDT
All reviewed patches have been landed.  Closing bug.