Bug 97308 - Build is broken with GLib Unicode backend
Summary: Build is broken with GLib Unicode backend
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-21 01:25 PDT by Thierry Reding
Modified: 2012-09-22 04:32 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.02 KB, patch)
2012-09-21 01:35 PDT, Thierry Reding 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thierry Reding 2012-09-21 01:25:19 PDT 
The TextBreakIteratorGtk implementation uses ubrk_close() to delete
the iterator. However that function is ICU specific and not declared
when using the GLib backend.

A patch for this has been proposed here:

  http://permalink.gmane.org/gmane.os.opendarwin.webkit.gtk/1210

I'll follow up with a patch with the proper ChangeLog updates.
Comment 1 Thierry Reding 2012-09-21 01:35:32 PDT 
Created attachment 165078 [details]
Patch
Comment 2 Carlos Garcia Campos 2012-09-21 10:03:24 PDT 
Comment on attachment 165078 [details]
Patch

Thanks!
Comment 3 Thierry Reding 2012-09-22 04:13:43 PDT 
(In reply to comment #2)
> (From update of attachment 165078 [details])
> Thanks!

Great. I'm unfamiliar with the procedure and what to do next. Do
I repost the patch marking it reviewed by you? Or will somebody
with commit access take care of it?
Comment 4 WebKit Review Bot 2012-09-22 04:32:09 PDT 
Comment on attachment 165078 [details]
Patch

Clearing flags on attachment: 165078

Committed r129305: <http://trac.webkit.org/changeset/129305>
Comment 5 WebKit Review Bot 2012-09-22 04:32:12 PDT 
All reviewed patches have been landed.  Closing bug.