After building, libewk2UnitTestInjectedBundleSample.so library is created in the Source/WebKit2/UIProcess/API/efl/tests/resources/. But the path was in the Source directory, so it will be better to move it under the build directory.
Created attachment 165067 [details] Patch
Comment on attachment 165067 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165067&action=review > Source/WebKit2/PlatformEfl.cmake:307 > + INSTALL(TARGETS ewk2UnitTestInjectedBundleSample DESTINATION "${LIB_INSTALL_DIR}") We don't have to install test library. :-)
Comment on attachment 165067 [details] Patch Yeah, INSTALLing that library is the wrong approach. You just need to adjust the LIBRARY_OUTPUT_DIRECTORY.
(In reply to comment #3) > (From update of attachment 165067 [details]) > Yeah, INSTALLing that library is the wrong approach. You just need to adjust the LIBRARY_OUTPUT_DIRECTORY. Yes you are right. I'm preparing like above. Thanks Kangil and Kubo :)
(In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 165067 [details] [details]) > > Yeah, INSTALLing that library is the wrong approach. You just need to adjust the LIBRARY_OUTPUT_DIRECTORY. > > Yes you are right. I'm preparing like above. Thanks Kangil and Kubo :) I found some unnecessary dependency for ewk2UnitTestInjectedBundleSample with ewk2UnitTestUtils, so I'll fix this also. Before removing the dependency, I met a SegFault on unit test at test_ewk2_context some times, but with removing this, the SegFault not found.
Created attachment 165105 [details] Patch
(In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > (From update of attachment 165067 [details] [details] [details]) > > > Yeah, INSTALLing that library is the wrong approach. You just need to adjust the LIBRARY_OUTPUT_DIRECTORY. > > > > Yes you are right. I'm preparing like above. Thanks Kangil and Kubo :) > > I found some unnecessary dependency for ewk2UnitTestInjectedBundleSample with ewk2UnitTestUtils, so I'll fix this also. > > Before removing the dependency, I met a SegFault on unit test at test_ewk2_context some times, but with removing this, the SegFault not found. BTW, why you move the code? Is it also necessary?
+(In reply to comment #7) > (In reply to comment #5) > > (In reply to comment #4) > > > (In reply to comment #3) > > > > (From update of attachment 165067 [details] [details] [details] [details]) > > > > Yeah, INSTALLing that library is the wrong approach. You just need to adjust the LIBRARY_OUTPUT_DIRECTORY. > > > > > > Yes you are right. I'm preparing like above. Thanks Kangil and Kubo :) > > > > I found some unnecessary dependency for ewk2UnitTestInjectedBundleSample with ewk2UnitTestUtils, so I'll fix this also. > > > > Before removing the dependency, I met a SegFault on unit test at test_ewk2_context some times, but with removing this, the SegFault not found. > > BTW, why you move the code? > > Is it also necessary? I moved it to add definition for the library path. But As you pointed, removing library dependency or moving some code is not necessary for changing library path. I'll just change the library path. Thank you :)
Created attachment 165256 [details] Patch
Comment on attachment 165256 [details] Patch Looks fine. Please land after verifying if this patch doesn't influence unit test on debug and release build.
Comment on attachment 165256 [details] Patch I tested on debug/release and ok. Thank you :)
Comment on attachment 165256 [details] Patch This still looks wrong. The library is being automatically put into ${CMAKE_BINARY_DIR}/lib because of the way we set the CMAKE_LIBRARY_OUTPUT_DIRECTORY variable in the top-level CMakeLists.txt; using ${LIB_INSTALL_DIR} like you did does not make much sense, as LIB_SUFFIX is not used by CMAKE_LIBRARY_OUTPUT_DIRECTORY. Just setting TEST_LIB_DIR to ${CMAKE_LIBRARY_OUTPUT_DIRECTORY} should be fine.
(In reply to comment #12) > (From update of attachment 165256 [details]) > This still looks wrong. > > The library is being automatically put into ${CMAKE_BINARY_DIR}/lib because of the way we set the CMAKE_LIBRARY_OUTPUT_DIRECTORY variable in the top-level CMakeLists.txt; using ${LIB_INSTALL_DIR} like you did does not make much sense, as LIB_SUFFIX is not used by CMAKE_LIBRARY_OUTPUT_DIRECTORY. > > Just setting TEST_LIB_DIR to ${CMAKE_LIBRARY_OUTPUT_DIRECTORY} should be fine. Ok, It will be more clear and safe. Thanks for pointing it.
Created attachment 165307 [details] Patch
(In reply to comment #14) > Created an attachment (id=165307) [details] > Patch I tested on Debug/Release and it works ok.
Created attachment 165308 [details] Patch
Comment on attachment 165308 [details] Patch Thanks!
Comment on attachment 165308 [details] Patch Clearing flags on attachment: 165308 Committed r129352: <http://trac.webkit.org/changeset/129352>
All reviewed patches have been landed. Closing bug.