Bug 97302 - [EFL][WK2] Change the install path for libewk2UnitTestInjectedBundleSample.so
Summary: [EFL][WK2] Change the install path for libewk2UnitTestInjectedBundleSample.so
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Byungwoo Lee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-21 00:04 PDT by Byungwoo Lee
Modified: 2012-09-24 05:31 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.82 KB, patch)
2012-09-21 00:29 PDT, Byungwoo Lee
no flags Details | Formatted Diff | Diff
Patch (3.96 KB, patch)
2012-09-21 03:08 PDT, Byungwoo Lee
no flags Details | Formatted Diff | Diff
Patch (2.72 KB, patch)
2012-09-22 03:13 PDT, Byungwoo Lee
no flags Details | Formatted Diff | Diff
Patch (2.76 KB, patch)
2012-09-23 21:23 PDT, Byungwoo Lee
no flags Details | Formatted Diff | Diff
Patch (2.76 KB, patch)
2012-09-23 21:28 PDT, Byungwoo Lee
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Byungwoo Lee 2012-09-21 00:04:02 PDT
After building, libewk2UnitTestInjectedBundleSample.so library is created in the Source/WebKit2/UIProcess/API/efl/tests/resources/.
But the path was in the Source directory, so it will be better to move it under the build directory.
Comment 1 Byungwoo Lee 2012-09-21 00:29:42 PDT
Created attachment 165067 [details]
Patch
Comment 2 Kangil Han 2012-09-21 02:28:38 PDT
Comment on attachment 165067 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165067&action=review

> Source/WebKit2/PlatformEfl.cmake:307
> +    INSTALL(TARGETS ewk2UnitTestInjectedBundleSample DESTINATION "${LIB_INSTALL_DIR}")

We don't have to install test library. :-)
Comment 3 Raphael Kubo da Costa (:rakuco) 2012-09-21 02:47:57 PDT
Comment on attachment 165067 [details]
Patch

Yeah, INSTALLing that library is the wrong approach. You just need to adjust the LIBRARY_OUTPUT_DIRECTORY.
Comment 4 Byungwoo Lee 2012-09-21 03:01:44 PDT
(In reply to comment #3)
> (From update of attachment 165067 [details])
> Yeah, INSTALLing that library is the wrong approach. You just need to adjust the LIBRARY_OUTPUT_DIRECTORY.

Yes you are right. I'm preparing like above. Thanks Kangil and Kubo :)
Comment 5 Byungwoo Lee 2012-09-21 03:07:11 PDT
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 165067 [details] [details])
> > Yeah, INSTALLing that library is the wrong approach. You just need to adjust the LIBRARY_OUTPUT_DIRECTORY.
> 
> Yes you are right. I'm preparing like above. Thanks Kangil and Kubo :)

I found some unnecessary dependency for ewk2UnitTestInjectedBundleSample with ewk2UnitTestUtils, so I'll fix this also.

Before removing the dependency, I met a SegFault on unit test at test_ewk2_context some times, but with removing this, the SegFault not found.
Comment 6 Byungwoo Lee 2012-09-21 03:08:27 PDT
Created attachment 165105 [details]
Patch
Comment 7 Ryuan Choi 2012-09-21 03:42:17 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > (From update of attachment 165067 [details] [details] [details])
> > > Yeah, INSTALLing that library is the wrong approach. You just need to adjust the LIBRARY_OUTPUT_DIRECTORY.
> > 
> > Yes you are right. I'm preparing like above. Thanks Kangil and Kubo :)
> 
> I found some unnecessary dependency for ewk2UnitTestInjectedBundleSample with ewk2UnitTestUtils, so I'll fix this also.
> 
> Before removing the dependency, I met a SegFault on unit test at test_ewk2_context some times, but with removing this, the SegFault not found.

BTW, why you move the code?

Is it also necessary?
Comment 8 Byungwoo Lee 2012-09-22 03:09:55 PDT
+(In reply to comment #7)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > (In reply to comment #3)
> > > > (From update of attachment 165067 [details] [details] [details] [details])
> > > > Yeah, INSTALLing that library is the wrong approach. You just need to adjust the LIBRARY_OUTPUT_DIRECTORY.
> > > 
> > > Yes you are right. I'm preparing like above. Thanks Kangil and Kubo :)
> > 
> > I found some unnecessary dependency for ewk2UnitTestInjectedBundleSample with ewk2UnitTestUtils, so I'll fix this also.
> > 
> > Before removing the dependency, I met a SegFault on unit test at test_ewk2_context some times, but with removing this, the SegFault not found.
> 
> BTW, why you move the code?
> 
> Is it also necessary?
I moved it to add definition for the library path.
But As you pointed, removing library dependency or moving some code is not necessary for changing library path.
I'll just change the library path.
Thank you :)
Comment 9 Byungwoo Lee 2012-09-22 03:13:57 PDT
Created attachment 165256 [details]
Patch
Comment 10 Gyuyoung Kim 2012-09-22 19:45:35 PDT
Comment on attachment 165256 [details]
Patch

Looks fine. Please land after verifying if this patch doesn't influence unit test on debug and release build.
Comment 11 Byungwoo Lee 2012-09-22 21:14:50 PDT
Comment on attachment 165256 [details]
Patch

I tested on debug/release and ok.
Thank you :)
Comment 12 Raphael Kubo da Costa (:rakuco) 2012-09-23 10:35:20 PDT
Comment on attachment 165256 [details]
Patch

This still looks wrong.

The library is being automatically put into ${CMAKE_BINARY_DIR}/lib because of the way we set the CMAKE_LIBRARY_OUTPUT_DIRECTORY variable in the top-level CMakeLists.txt; using ${LIB_INSTALL_DIR} like you did does not make much sense, as LIB_SUFFIX is not used by CMAKE_LIBRARY_OUTPUT_DIRECTORY.

Just setting TEST_LIB_DIR to ${CMAKE_LIBRARY_OUTPUT_DIRECTORY} should be fine.
Comment 13 Byungwoo Lee 2012-09-23 19:03:29 PDT
(In reply to comment #12)
> (From update of attachment 165256 [details])
> This still looks wrong.
> 
> The library is being automatically put into ${CMAKE_BINARY_DIR}/lib because of the way we set the CMAKE_LIBRARY_OUTPUT_DIRECTORY variable in the top-level CMakeLists.txt; using ${LIB_INSTALL_DIR} like you did does not make much sense, as LIB_SUFFIX is not used by CMAKE_LIBRARY_OUTPUT_DIRECTORY.
> 
> Just setting TEST_LIB_DIR to ${CMAKE_LIBRARY_OUTPUT_DIRECTORY} should be fine.

Ok, It will be more clear and safe. Thanks for pointing it.
Comment 14 Byungwoo Lee 2012-09-23 21:23:55 PDT
Created attachment 165307 [details]
Patch
Comment 15 Byungwoo Lee 2012-09-23 21:26:37 PDT
(In reply to comment #14)
> Created an attachment (id=165307) [details]
> Patch

I tested on Debug/Release and it works ok.
Comment 16 Byungwoo Lee 2012-09-23 21:28:16 PDT
Created attachment 165308 [details]
Patch
Comment 17 Raphael Kubo da Costa (:rakuco) 2012-09-24 05:24:38 PDT
Comment on attachment 165308 [details]
Patch

Thanks!
Comment 18 WebKit Review Bot 2012-09-24 05:31:36 PDT
Comment on attachment 165308 [details]
Patch

Clearing flags on attachment: 165308

Committed r129352: <http://trac.webkit.org/changeset/129352>
Comment 19 WebKit Review Bot 2012-09-24 05:31:40 PDT
All reviewed patches have been landed.  Closing bug.