RESOLVED FIXED Bug 97300
[Forms] DateTimeEditElement::layout() should take date time format as a parameter 
https://bugs.webkit.org/show_bug.cgi?id=97300
Summary [Forms] DateTimeEditElement::layout() should take date time format as a param...
yosin
Reported 2012-09-20 23:52:26 PDT
To use DateTimeEditElement other than "time" input type, such as "date", "datetime", "month", or "week", DateTimeEditElement::layout() should take date time format as a parameter instead of calling Localizer::timeFormat().
Attachments
Patch 1 (12.12 KB, patch)
2012-09-21 00:07 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 2 (12.00 KB, patch)
2012-09-21 02:52 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-09-21 00:07:16 PDT
Created attachment 165059 [details] Patch 1
yosin
Comment 2 2012-09-21 00:08:53 PDT
Comment on attachment 165059 [details] Patch 1 Could you review this patch? Thanks in advance.
Kent Tamura
Comment 3 2012-09-21 01:42:37 PDT
Comment on attachment 165059 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=165059&action=review > Source/WebCore/html/TimeInputType.cpp:311 > + bool const hasValue = parseToDateComponents(element()->value(), &date); We usually put "const" followed by a type name. const bool hasValue ... > Source/WebCore/html/shadow/DateTimeEditElement.cpp:410 > +bool DateTimeEditElement::shouldHaveSecondField(const LayoutParameters& layoutParameters) This should be a member of LayoutParameters.
yosin
Comment 4 2012-09-21 02:52:31 PDT
Created attachment 165097 [details] Patch 2
yosin
Comment 5 2012-09-21 02:54:05 PDT
Comment on attachment 165097 [details] Patch 2 Could you review this patch? Thanks in advance. = Changes since the last review = * Fix position of "const". * Move shouldHaveSecondField to LayoutParameters.
Kent Tamura
Comment 6 2012-09-21 02:56:15 PDT
Comment on attachment 165097 [details] Patch 2 ok
yosin
Comment 7 2012-09-21 03:05:44 PDT
Comment on attachment 165097 [details] Patch 2 Clearing flags on attachment: 165097 Committed r129206: <http://trac.webkit.org/changeset/129206>
yosin
Comment 8 2012-09-21 03:05:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.