I have local changes: > git status # On branch WKTRTiledDrawing # # Changes not staged for commit: # (use "git add <file>..." to update what will be committed) # (use "git checkout -- <file>..." to discard changes in working directory) # # modified: Tools/ChangeLog # modified: Tools/WebKitTestRunner/TestController.cpp # modified: Tools/WebKitTestRunner/TestController.h # modified: Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm But check-webkit-style is going nuts checking all the files: LayoutTests/platform/efl/tables/mozilla/bugs/bug13105-expected.png:0: Have to enable auto props in the subversion config file (/Users/hortont/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/Users/hortont/.subversion/config "*.png = svn:mime-type=image/png"). [image/png] [5] WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp:34: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/inspector/InjectedScriptCanvasModule.h:59: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] And so on and so forth. This is definitely not how it used to work. (unless I'm missing something
What is the branch structure of your repository? If you've done a non-fast-forward merge of origin/master, then we might not be computing the diff you expect.
(In reply to comment #1) > What is the branch structure of your repository? If you've done a non-fast-forward merge of origin/master, then we might not be computing the diff you expect. That seems a bit odd, I'd expect check-webkit-style to check the same set of files prepare-ChangeLog will write a changelog about...
That's more or less what it used to do, but there was a discussion on webkit-dev a while back where folks asked for different semantics.
Okiedokie.
hm. don't remember that discussion. I certainly wouldn't expect it to be trying to check baselines or expectations files if they weren't changed ...
It's not checking the diff since HEAD it's checking the diff against origin/master (or whatever I really mean in git-speak).
(In reply to comment #6) > It's not checking the diff since HEAD it's checking the diff against origin/master (or whatever I really mean in git-speak). Oh. That seems more reasonable :).