Bug 97293 - [EFL] Several MathML tests need rebaseline after r129146
Summary: [EFL] Several MathML tests need rebaseline after r129146
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Depends on:
Blocks: 97228
  Show dependency treegraph
Reported: 2012-09-20 22:40 PDT by Chris Dumez
Modified: 2012-09-20 23:29 PDT (History)
8 users (show)

See Also:

Patch (715.16 KB, patch)
2012-09-20 22:53 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-09-20 22:40:08 PDT
We need to rebaseline several MathML tests due to r129146.
Comment 1 Chris Dumez 2012-09-20 22:53:12 PDT
Created attachment 165054 [details]

Could someone please cq+ ?
Comment 2 WebKit Review Bot 2012-09-20 23:14:18 PDT
Comment on attachment 165054 [details]

Clearing flags on attachment: 165054

Committed r129193: <http://trac.webkit.org/changeset/129193>
Comment 3 WebKit Review Bot 2012-09-20 23:14:22 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Dave Barton 2012-09-20 23:29:00 PDT
I just looked at the 17 efl .txt diffs and the 20 gtk .txt diffs on the bots, and they all look similar to the mac ones for bug 97228. I think you can just rebaseline. Update: I now see your patch, the 17 .png file changes look fine to me too.

I am sorry to keep doing this to you. However, I'm just a volunteer and I inherited these MathML tests. I converted a few others to reference tests, but it's harder to change these. I'm not sure what WebKit's preferred method for handling this is.

I do notice that the old platform/efl/mathml/presentation/*.txt and platform/gtk/mathml/presentation/*.txt expected results are identical I believe (except that efl turns 3 tests off). Can we use the layout test expected results search path to somehow have a single directory of linux expected results, that will be used for both efl and gtk? Perhaps it could be used for the Chromium linux port as well?