RESOLVED FIXED 97292
Add datalist suggestions into DateTimeChooserParameters 
https://bugs.webkit.org/show_bug.cgi?id=97292
Summary Add datalist suggestions into DateTimeChooserParameters
Keishi Hattori
Reported 2012-09-20 22:32:39 PDT
Populate datalist suggestions into DateTimeChooserParameters
Attachments
Patch (5.61 KB, patch)
2012-09-20 22:40 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (5.59 KB, patch)
2012-09-21 00:01 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2012-09-20 22:40:23 PDT
Created attachment 165052 [details] Patch
Kent Tamura
Comment 2 2012-09-20 22:54:22 PDT
Comment on attachment 165052 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165052&action=review > Source/WebCore/html/shadow/CalendarPickerElement.cpp:146 > + HTMLDataListElement* dataList = input->dataList(); > + if (dataList) { nit: if (HTMLDataList* datalist = ...) { is simpler. > Source/WebCore/html/shadow/CalendarPickerElement.cpp:148 > + for (unsigned i = 0; HTMLOptionElement* option = static_cast<HTMLOptionElement*>(options->item(i)); i++) { Use toHTMLOptionElement() instead of static_cast<>. We prefer ++i.
Keishi Hattori
Comment 3 2012-09-21 00:01:40 PDT
Created attachment 165058 [details] Patch
Kent Tamura
Comment 4 2012-09-21 00:06:08 PDT
Comment on attachment 165058 [details] Patch ok
WebKit Review Bot
Comment 5 2012-09-21 03:08:10 PDT
Comment on attachment 165058 [details] Patch Clearing flags on attachment: 165058 Committed r129207: <http://trac.webkit.org/changeset/129207>
WebKit Review Bot
Comment 6 2012-09-21 03:08:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.