Bug 97292 - Add datalist suggestions into DateTimeChooserParameters
Summary: Add datalist suggestions into DateTimeChooserParameters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks: 96085
  Show dependency tree / graph
 
Reported: 2012-09-20 22:32 PDT by Keishi Hattori
Modified: 2012-09-21 03:08 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.61 KB, patch)
2012-09-20 22:40 PDT, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (5.59 KB, patch)
2012-09-21 00:01 PDT, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2012-09-20 22:32:39 PDT 
Populate datalist suggestions into DateTimeChooserParameters
Comment 1 Keishi Hattori 2012-09-20 22:40:23 PDT 
Created attachment 165052 [details]
Patch
Comment 2 Kent Tamura 2012-09-20 22:54:22 PDT 
Comment on attachment 165052 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165052&action=review

> Source/WebCore/html/shadow/CalendarPickerElement.cpp:146
> +    HTMLDataListElement* dataList = input->dataList();
> +    if (dataList) {

nit:
if (HTMLDataList* datalist = ...) {

is simpler.

> Source/WebCore/html/shadow/CalendarPickerElement.cpp:148
> +        for (unsigned i = 0; HTMLOptionElement* option = static_cast<HTMLOptionElement*>(options->item(i)); i++) {

Use toHTMLOptionElement() instead of static_cast<>.
We prefer ++i.
Comment 3 Keishi Hattori 2012-09-21 00:01:40 PDT 
Created attachment 165058 [details]
Patch
Comment 4 Kent Tamura 2012-09-21 00:06:08 PDT 
Comment on attachment 165058 [details]
Patch

ok
Comment 5 WebKit Review Bot 2012-09-21 03:08:10 PDT 
Comment on attachment 165058 [details]
Patch

Clearing flags on attachment: 165058

Committed r129207: <http://trac.webkit.org/changeset/129207>
Comment 6 WebKit Review Bot 2012-09-21 03:08:14 PDT 
All reviewed patches have been landed.  Closing bug.