Both GraphicsContext3D::validateAttributes() and GraphicsContext3D::validateDepthStencil() have this code if (m_attrs.antialias) { bool isValidVendor = true; // Currently in Mac we only turn on antialias if vendor is NVIDIA, // or if ATI and on 10.7.2 and above. const char* vendor = reinterpret_cast<const char*>(::glGetString(GL_VENDOR)); if (!vendor || (!std::strstr(vendor, "NVIDIA") && !(std::strstr(vendor, "ATI") && systemAllowsMultisamplingOnATICards()))) isValidVendor = false; if (!isValidVendor || !extensions->supports("GL_ANGLE_framebuffer_multisample") || isGLES2Compliant()) m_attrs.antialias = false; else extensions->ensureEnabled("GL_ANGLE_framebuffer_multisample"); } And validateAttributes() calls validateDepthStencil() so we are calling this twice? Can the code be shared? Or does on copy need to be deleted?
Created attachment 179118 [details] Patch
Comment on attachment 179118 [details] Patch Attachment 179118 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15284606
Comment on attachment 179118 [details] Patch Attachment 179118 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15285461
Created attachment 179124 [details] Patch
Comment on attachment 179124 [details] Patch Clearing flags on attachment: 179124 Committed r137606: <http://trac.webkit.org/changeset/137606>
All reviewed patches have been landed. Closing bug.