Bug 97272 - Web Inspector: UISourceCode commitWorkingCopy should not fail when original script had syntax error.
Summary: Web Inspector: UISourceCode commitWorkingCopy should not fail when original s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-20 16:37 PDT by johnjbarton
Modified: 2012-10-03 07:37 PDT (History)
12 users (show)

See Also:

Attachments
Patch (5.55 KB, patch)
2012-09-20 16:49 PDT, johnjbarton 		no flags Details | Formatted Diff | Diff
Patch (7.55 KB, patch)
2012-10-03 03:02 PDT, Vsevolod Vlasov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description johnjbarton 2012-09-20 16:37:07 PDT 
See 
http://code.google.com/p/chromium/issues/detail?id=151399

Note that the relevant LayoutTests file is live-edit.html but it is allowed to fail by a line in 
platform/chromium/TestExpectations
See Bug 91435
Comment 1 johnjbarton 2012-09-20 16:49:33 PDT 
Created attachment 165013 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-09-24 05:12:28 PDT 
Comment on attachment 165013 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165013&action=review

> Source/WebCore/inspector/front-end/JavaScriptSource.js:104
> +            var rawLocation = this.uiLocationToRawLocation(0, 0);

We try to avoid exceptions in inspector code.
Why not use 
if (!rawLocation)
    return;
instead?

> LayoutTests/inspector/debugger/live-edit.html:14
> +    WebInspector.showPanel("scripts");

var panel = WebInspector.showPanel("scripts");
Comment 3 Vsevolod Vlasov 2012-10-03 03:02:37 PDT 
Created attachment 166842 [details]
Patch
Comment 4 WebKit Review Bot 2012-10-03 07:37:27 PDT 
Comment on attachment 166842 [details]
Patch

Clearing flags on attachment: 166842

Committed r130287: <http://trac.webkit.org/changeset/130287>
Comment 5 WebKit Review Bot 2012-10-03 07:37:30 PDT 
All reviewed patches have been landed.  Closing bug.