Bug 97260 - CHECK_ARRAY_CONSISTENCY isn't being used or tested, so we should remove it
Summary: CHECK_ARRAY_CONSISTENCY isn't being used or tested, so we should remove it
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-20 13:42 PDT by Filip Pizlo
Modified: 2012-09-20 16:38 PDT (History)
8 users (show)

See Also:


Attachments
patch for landing (17.66 KB, patch)
2012-09-20 14:19 PDT, Filip Pizlo
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-09-20 13:42:22 PDT
Rubber stamped by Geoff Garen.
Comment 1 Filip Pizlo 2012-09-20 14:19:46 PDT
Created attachment 164978 [details]
patch for landing
Comment 2 WebKit Review Bot 2012-09-20 14:26:12 PDT
Comment on attachment 164978 [details]
patch for landing

Rejecting attachment 164978 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Geoff Garen found in /mnt/git/webkit-commit-queue/Source/JavaScriptCore/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /mnt/git/webkit-commit-queue/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13953277
Comment 3 Filip Pizlo 2012-09-20 14:55:59 PDT
(In reply to comment #2)
> (From update of attachment 164978 [details])
> Rejecting attachment 164978 [details] from commit-queue.
> 
> Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1
> 
> Geoff Garen found in /mnt/git/webkit-commit-queue/Source/JavaScriptCore/ChangeLog does not appear to be a valid reviewer according to committers.py.
> ERROR: /mnt/git/webkit-commit-queue/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
> 
> Full output: http://queues.webkit.org/results/13953277

Committing manually.
Comment 4 Filip Pizlo 2012-09-20 16:38:55 PDT
Landed in http://trac.webkit.org/changeset/129179