WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
97255
[chromium] Remove unused copy of chromium compositor implementation files
https://bugs.webkit.org/show_bug.cgi?id=97255
Summary
[chromium] Remove unused copy of chromium compositor implementation files
James Robinson
Reported
2012-09-20 13:14:59 PDT
[chromium] Remove unused copy of chromium compositor implementation files
Attachments
just the gyp and changes, not the removes
(50.59 KB, patch)
2012-09-20 13:27 PDT
,
James Robinson
abarth
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
James Robinson
Comment 1
2012-09-20 13:16:25 PDT
Diffstat for giggles: 306 files changed, 19 insertions(+), 69612 deletions(-)
James Robinson
Comment 2
2012-09-20 13:17:54 PDT
Oh noes, webkit-patch isn't letting me upload the patch! I'll try just uploading the .gyp + actual files changes without the rms and see how that goes
James Robinson
Comment 3
2012-09-20 13:27:35 PDT
Created
attachment 164971
[details]
just the gyp and changes, not the removes
James Robinson
Comment 4
2012-09-20 13:34:07 PDT
Committed
r129160
: <
http://trac.webkit.org/changeset/129160
>
Eric Seidel (no email)
Comment 5
2012-09-20 13:37:09 PDT
Fantastic!
Eric Seidel (no email)
Comment 6
2012-09-20 13:37:43 PDT
(In reply to
comment #2
)
> Oh noes, webkit-patch isn't letting me upload the patch! I'll try just uploading the .gyp + actual files changes without the rms and see how that goes
Sadly I bet it's silently failing, when it doesn't understand bugzilla's "your patch is too big" error message. :(
James Robinson
Comment 7
2012-09-20 13:40:53 PDT
(In reply to
comment #6
)
> (In reply to
comment #2
) > > Oh noes, webkit-patch isn't letting me upload the patch! I'll try just uploading the .gyp + actual files changes without the rms and see how that goes > > Sadly I bet it's silently failing, when it doesn't understand bugzilla's "your patch is too big" error message. :(
Yup, it is (was). Not a big deal if you realize what's going on.
Eric Seidel (no email)
Comment 8
2012-09-20 14:27:15 PDT
That's webkit-patch
bug 72863
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug