Bug 97255 - [chromium] Remove unused copy of chromium compositor implementation files
Summary: [chromium] Remove unused copy of chromium compositor implementation files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-20 13:14 PDT by James Robinson
Modified: 2012-10-04 00:54 PDT (History)
7 users (show)

See Also:


Attachments
just the gyp and changes, not the removes (50.59 KB, patch)
2012-09-20 13:27 PDT, James Robinson
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-09-20 13:14:59 PDT
[chromium] Remove unused copy of chromium compositor implementation files
Comment 1 James Robinson 2012-09-20 13:16:25 PDT
Diffstat for giggles:

 306 files changed, 19 insertions(+), 69612 deletions(-)
Comment 2 James Robinson 2012-09-20 13:17:54 PDT
Oh noes, webkit-patch isn't letting me upload the patch!  I'll try just uploading the .gyp + actual files changes without the rms and see how that goes
Comment 3 James Robinson 2012-09-20 13:27:35 PDT
Created attachment 164971 [details]
just the gyp and changes, not the removes
Comment 4 James Robinson 2012-09-20 13:34:07 PDT
Committed r129160: <http://trac.webkit.org/changeset/129160>
Comment 5 Eric Seidel (no email) 2012-09-20 13:37:09 PDT
Fantastic!
Comment 6 Eric Seidel (no email) 2012-09-20 13:37:43 PDT
(In reply to comment #2)
> Oh noes, webkit-patch isn't letting me upload the patch!  I'll try just uploading the .gyp + actual files changes without the rms and see how that goes

Sadly I bet it's silently failing, when it doesn't understand bugzilla's "your patch is too big" error message. :(
Comment 7 James Robinson 2012-09-20 13:40:53 PDT
(In reply to comment #6)
> (In reply to comment #2)
> > Oh noes, webkit-patch isn't letting me upload the patch!  I'll try just uploading the .gyp + actual files changes without the rms and see how that goes
> 
> Sadly I bet it's silently failing, when it doesn't understand bugzilla's "your patch is too big" error message. :(

Yup, it is (was).  Not a big deal if you realize what's going on.
Comment 8 Eric Seidel (no email) 2012-09-20 14:27:15 PDT
That's webkit-patch bug 72863.