Bug 97253 - webkit-patch land fails with "AttributeError: 'NoneType' object has no attribute 'contents'"
Summary: webkit-patch land fails with "AttributeError: 'NoneType' object has no attrib...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-20 12:59 PDT by Ryosuke Niwa
Modified: 2017-07-18 08:29 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-09-20 12:59:36 PDT 
$ Tools/Scripts/webkit-patch land
Fetching: https://bugs.webkit.org/show_bug.cgi?id=97155&ctype=xml&excludefield=attachmentdata
Guessing "Hajime Morita" as reviewer from attachment 164811 [details] on bug 97155.
Traceback (most recent call last):
  File "Tools/Scripts/webkit-patch", line 84, in <module>
    main()
  File "Tools/Scripts/webkit-patch", line 79, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/Users/rniwa/webkit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 311, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Users/rniwa/webkit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 120, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Users/rniwa/webkit/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 51, in execute
    self._sequence.run_and_handle_errors(tool, options, state)
  File "/Users/rniwa/webkit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Users/rniwa/webkit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
    step(tool, options).run(state)
  File "/Users/rniwa/webkit/Tools/Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py", line 72, in run
    ChangeLog(changelog_path).set_reviewer(reviewer)
  File "/Users/rniwa/webkit/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 349, in set_reviewer
    latest_entry_contents = latest_entry.contents()
AttributeError: 'NoneType' object has no attribute 'contents'
Comment 1 Adam Barth 2012-09-20 13:01:16 PDT 
Looks like a parse error in the ChangeLog.  We should handle this error better.
Comment 2 Ryosuke Niwa 2012-09-20 13:03:36 PDT 
Looking at the change log, we have:

OB2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>

        run-perf-tests should record individual value instead of statistics
        https://bugs.webkit.org/show_bug.cgi?id=97155

I just did svn up & resolve-ChangeLogs. Maybe there's some bug/regression there?
Comment 3 Adam Barth 2012-09-20 13:17:07 PDT 
OB2012-09-19

^^ is the "OB" in the original?
Comment 4 Eric Seidel (no email) 2012-09-20 13:21:47 PDT 
I suspect th OB caused the problem.  I believe tehre is a bug on file about leading spaces on teh date line causing webkit-patch to barf kittens.
Comment 5 Ryosuke Niwa 2012-09-20 13:25:39 PDT 
(In reply to comment #3)
> OB2012-09-19
> 
> ^^ is the "OB" in the original?

Hm... it appears that it was in the original patch. Not sure how it got there.