Bug 97253 – webkit-patch land fails with "AttributeError: 'NoneType' object has no attribute 'contents'"

• Status: NEW
• Component: Tools / Tests

[Ryosuke Niwa]

$ Tools/Scripts/webkit-patch land
Fetching: https://bugs.webkit.org/show_bug.cgi?id=97155&ctype=xml&excludefield=attachmentdata
Guessing "Hajime Morita" as reviewer from attachment 164811 [details] on bug 97155.
Traceback (most recent call last):
  File "Tools/Scripts/webkit-patch", line 84, in <module>
    main()
  File "Tools/Scripts/webkit-patch", line 79, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/Users/rniwa/webkit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 311, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Users/rniwa/webkit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 120, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Users/rniwa/webkit/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 51, in execute
    self._sequence.run_and_handle_errors(tool, options, state)
  File "/Users/rniwa/webkit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Users/rniwa/webkit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
    step(tool, options).run(state)
  File "/Users/rniwa/webkit/Tools/Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py", line 72, in run
    ChangeLog(changelog_path).set_reviewer(reviewer)
  File "/Users/rniwa/webkit/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 349, in set_reviewer
    latest_entry_contents = latest_entry.contents()
AttributeError: 'NoneType' object has no attribute 'contents'

[Adam Barth]

Looks like a parse error in the ChangeLog.  We should handle this error better.

[Ryosuke Niwa]

Looking at the change log, we have:

OB2012-09-19  Ryosuke Niwa  <[e-mail]>

        run-perf-tests should record individual value instead of statistics
        https://bugs.webkit.org/show_bug.cgi?id=97155

I just did svn up & resolve-ChangeLogs. Maybe there's some bug/regression there?

[Adam Barth]

OB2012-09-19

^^ is the "OB" in the original?

[Eric Seidel (no email)]

I suspect th OB caused the problem.  I believe tehre is a bug on file about leading spaces on teh date line causing webkit-patch to barf kittens.

[Ryosuke Niwa]

(In reply to comment #3)
> OB2012-09-19
> 
> ^^ is the "OB" in the original?

Hm... it appears that it was in the original patch. Not sure how it got there.