WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 97248
[chromium] Rebaseline gesture highlight test expectation images.
https://bugs.webkit.org/show_bug.cgi?id=97248
Summary
[chromium] Rebaseline gesture highlight test expectation images.
W. James MacLean
Reported
2012-09-20 12:15:41 PDT
[chromium] Rebaseline gesture highlight test expectation images.
Attachments
Patch
(751.80 KB, patch)
2012-09-20 12:17 PDT
,
W. James MacLean
no flags
Details
Formatted Diff
Diff
Patch for landing
(751.89 KB, patch)
2012-09-24 09:28 PDT
,
W. James MacLean
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
W. James MacLean
Comment 1
2012-09-20 12:17:05 PDT
Created
attachment 164964
[details]
Patch
W. James MacLean
Comment 2
2012-09-20 12:20:04 PDT
I'd like to keep the baseline images up to date even though at present these tests are skipped.
Yuta Kitamura
Comment 3
2012-09-20 21:54:35 PDT
Comment on
attachment 164964
[details]
Patch What's the difference? I couldn't spot the difference between the old and new images. (And it might be better to refer the difference in the ChangeLog.)
W. James MacLean
Comment 4
2012-09-21 07:31:49 PDT
There are subtle changes in the text for the selected links ... it's not perceptable to the naked eye, but ImageDiff picks it up. I'm willing to expand that comment at the time I submit ...
Yuta Kitamura
Comment 5
2012-09-21 16:26:32 PDT
Comment on
attachment 164964
[details]
Patch OK, please amend the ChangeLog when landing.
W. James MacLean
Comment 6
2012-09-24 09:28:07 PDT
Created
attachment 165395
[details]
Patch for landing
WebKit Review Bot
Comment 7
2012-09-24 10:10:50 PDT
Comment on
attachment 165395
[details]
Patch for landing Clearing flags on attachment: 165395 Committed
r129384
: <
http://trac.webkit.org/changeset/129384
>
WebKit Review Bot
Comment 8
2012-09-24 10:10:53 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug