Bug 97248 - [chromium] Rebaseline gesture highlight test expectation images.
Summary: [chromium] Rebaseline gesture highlight test expectation images.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: W. James MacLean
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-20 12:15 PDT by W. James MacLean
Modified: 2012-09-24 10:10 PDT (History)
3 users (show)

See Also:

Attachments
Patch (751.80 KB, patch)
2012-09-20 12:17 PDT, W. James MacLean 		no flags Details | Formatted Diff | Diff
Patch for landing (751.89 KB, patch)
2012-09-24 09:28 PDT, W. James MacLean 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description W. James MacLean 2012-09-20 12:15:41 PDT 
[chromium] Rebaseline gesture highlight test expectation images.
Comment 1 W. James MacLean 2012-09-20 12:17:05 PDT 
Created attachment 164964 [details]
Patch
Comment 2 W. James MacLean 2012-09-20 12:20:04 PDT 
I'd like to keep the baseline images up to date even though at present these tests are skipped.
Comment 3 Yuta Kitamura 2012-09-20 21:54:35 PDT 
Comment on attachment 164964 [details]
Patch

What's the difference? I couldn't spot the difference between the old and new images. (And it might be better to refer the difference in the ChangeLog.)
Comment 4 W. James MacLean 2012-09-21 07:31:49 PDT 
There are subtle changes in the text for the selected links ... it's not perceptable to the naked eye, but ImageDiff picks it up. I'm willing to expand that comment at the time I submit ...
Comment 5 Yuta Kitamura 2012-09-21 16:26:32 PDT 
Comment on attachment 164964 [details]
Patch

OK, please amend the ChangeLog when landing.
Comment 6 W. James MacLean 2012-09-24 09:28:07 PDT 
Created attachment 165395 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-09-24 10:10:50 PDT 
Comment on attachment 165395 [details]
Patch for landing

Clearing flags on attachment: 165395

Committed r129384: <http://trac.webkit.org/changeset/129384>
Comment 8 WebKit Review Bot 2012-09-24 10:10:53 PDT 
All reviewed patches have been landed.  Closing bug.