Bug 97230 - [Chromium] Switch back to a fixed fifo path for Android
Summary: [Chromium] Switch back to a fixed fifo path for Android
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peter Beverloo
URL:
Keywords:
Depends on: 97227
Blocks:
  Show dependency tree / graph
 
Reported: 2012-09-20 10:06 PDT by Peter Beverloo
Modified: 2012-09-21 07:25 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.02 KB, patch)
2012-09-20 10:08 PDT, Peter Beverloo 		tony: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Beverloo 2012-09-20 10:06:17 PDT 
We *may* switch to using a fixed path to the fifo files rather than relying on the sd-card, considering not all external storage will be formatted with a file system that supports creating fifos.

While there is a small chance this will never have to land, I'd like to request review so we can re-enable running layout tests after that lands on the Chromium side and is pulled in to WebKit. This is, in a way, a preemptive layout-test-running fix.
Comment 1 Peter Beverloo 2012-09-20 10:08:42 PDT 
Created attachment 164936 [details]
Patch
Comment 2 Tony Chang 2012-09-20 10:56:31 PDT 
Comment on attachment 164936 [details]
Patch

OK, but you'll probably need to rebase.
Comment 3 Peter Beverloo 2012-09-21 07:25:00 PDT 
Committed r129226: <http://trac.webkit.org/changeset/129226>