Bug 97215 – [Qt] Make sure that desktop pages honour the devicePixelRatio

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jocelyn Turcotte]

[Qt] Make sure that desktop pages honour the devicePixelRatio

[Jocelyn Turcotte]

Created attachment 164921 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 164921 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164921&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:943
> +    int minimumLayoutFallbackWidth = std::max(settings->layoutFallbackWidth(), int(m_viewportSize.width() / m_page->deviceScaleFactor()));

so maybe ceil or lrint would make more sense?

[Jocelyn Turcotte]

(In reply to comment #2)
> (From update of attachment 164921 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=164921&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:943
> > +    int minimumLayoutFallbackWidth = std::max(settings->layoutFallbackWidth(), int(m_viewportSize.width() / m_page->deviceScaleFactor()));
> 
> so maybe ceil or lrint would make more sense?

Humm can't say, overall this is the desktop equivalent of the conversion to int did in WebPage::sendViewportAttributesChanged:
setResizesToContentsUsingLayoutSize(IntSize(static_cast<int>(attr.layoutSize.width()), static_cast<int>(attr.layoutSize.height())));

So if we change one we should change the other. Overall this can mean a difference of 1 pixel to the layout size, which could give a 1.501 scale instead of 1.502, nothing noticeable by the user.

[WebKit Review Bot]

Comment on attachment 164921 [details]
Patch

Clearing flags on attachment: 164921

Committed r129514: <http://trac.webkit.org/changeset/129514>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.