Bug 97196 - [Qt] Enable CSS regions by default
Summary: [Qt] Enable CSS regions by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2012-09-20 04:35 PDT by Csaba Osztrogonác
Modified: 2012-09-20 06:24 PDT (History)
4 users (show)

See Also:


Attachments
Patch (848.31 KB, patch)
2012-09-20 05:11 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2012-09-20 04:35:00 PDT
CSS region is built already, but it is disabled in runtime in qwebsettings.cpp by default.
I tested it, almost all tests pass, so it's time to enable it by default. Patch is coming soon.
Comment 1 Csaba Osztrogonác 2012-09-20 04:39:39 PDT
fast/regions/overflow-size-change-with-stacking-context.html - fails
fast/regions/css-regions-disabled.html - fails on Qt WK2

failing reftests with minor pixel differences:
fast/regions/floats-basic-in-variable-width-regions.html
fast/regions/positioned-objects-block-static-spanning-regions-rtl.html
fast/regions/region-style-rule-position.html
Comment 2 Csaba Osztrogonác 2012-09-20 05:11:00 PDT
Created attachment 164897 [details]
Patch
Comment 3 Csaba Osztrogonác 2012-09-20 05:13:01 PDT
(In reply to comment #1)
> fast/regions/overflow-size-change-with-stacking-context.html - fails
new bug: https://bugs.webkit.org/show_bug.cgi?id=97199

> fast/regions/css-regions-disabled.html - fails on Qt WK2
new bug: https://bugs.webkit.org/show_bug.cgi?id=97197
Comment 4 Dirk Schulze 2012-09-20 05:44:48 PDT
Comment on attachment 164897 [details]
Patch

LGTM. r=me
Comment 5 Csaba Osztrogonác 2012-09-20 06:24:38 PDT
Committed r129126: <http://trac.webkit.org/changeset/129126>