Bug 97195 - [Qt] r129045 broke the ARM build
Summary: [Qt] r129045 broke the ARM build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-20 04:30 PDT by Gabor Rapcsanyi
Modified: 2012-09-20 06:24 PDT (History)
5 users (show)

See Also:


Attachments
Speculative fix (1.89 KB, patch)
2012-09-20 04:46 PDT, Gabor Rapcsanyi
no flags Details | Formatted Diff | Diff
Speculative fix 2 (1.64 KB, patch)
2012-09-20 05:51 PDT, Gabor Rapcsanyi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Rapcsanyi 2012-09-20 04:30:37 PDT
MacroAssemblerARM.h is missing some store8() implementations.
Comment 1 Gabor Rapcsanyi 2012-09-20 04:46:22 PDT
Created attachment 164891 [details]
Speculative fix
Comment 2 Zoltan Herczeg 2012-09-20 04:57:26 PDT
I suggest to use:
move(TrustedImm32(reinterpret_cast<ARMWord>(address)), ARMRegisters::S0);

The immediate does not need to unique. I saw there are other places where these unique constats are used, we should remove them later.
Comment 3 Gabor Rapcsanyi 2012-09-20 05:51:31 PDT
Created attachment 164900 [details]
Speculative fix 2

I made the change what Zoltan mentioned and deleted the unnecessary store8(RegisterID src, void* address) implementation.
Comment 4 Zoltan Herczeg 2012-09-20 06:04:26 PDT
Comment on attachment 164900 [details]
Speculative fix 2

r=me
Comment 5 WebKit Review Bot 2012-09-20 06:24:51 PDT
Comment on attachment 164900 [details]
Speculative fix 2

Clearing flags on attachment: 164900

Committed r129127: <http://trac.webkit.org/changeset/129127>
Comment 6 WebKit Review Bot 2012-09-20 06:24:54 PDT
All reviewed patches have been landed.  Closing bug.