Bug 97193 - Prepare CalendarPicker so we can add another picker, SuggetionPicker
Summary: Prepare CalendarPicker so we can add another picker, SuggetionPicker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks: 96085
  Show dependency tree / graph
 
Reported: 2012-09-20 04:26 PDT by Keishi Hattori
Modified: 2012-09-21 00:02 PDT (History)
2 users (show)

See Also:

Attachments
Patch (7.62 KB, patch)
2012-09-20 04:48 PDT, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (6.87 KB, patch)
2012-09-20 22:27 PDT, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2012-09-20 04:26:35 PDT 
Prepare CalendarPicker so we can add another picker, SuggetionPicker
Comment 1 Keishi Hattori 2012-09-20 04:48:39 PDT 
Created attachment 164892 [details]
Patch
Comment 2 Kent Tamura 2012-09-20 06:12:00 PDT 
Comment on attachment 164892 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164892&action=review

> Source/WebCore/Resources/pagepopups/calendarPicker.js:382
> -    var elementHeight = this._element.offsetHeight;
>      this._element.style.width = "auto";
>      daysAreaElement.style.width = "100%";
>      daysAreaElement.style.tableLayout = "fixed";
>      this._element.getElementsByClassName(ClassNames.YearMonthUpper)[0].style.display = "-webkit-box";
>      this._element.getElementsByClassName(ClassNames.MonthSelectorBox)[0].style.display = "block";
> +    var elementHeight = this._element.offsetHeight;

Why do you move elementHeight?

ChangeLog should explain such reasons of changes.
Comment 3 Keishi Hattori 2012-09-20 22:27:30 PDT 
Created attachment 165047 [details]
Patch
Comment 4 Keishi Hattori 2012-09-20 22:27:42 PDT 
(In reply to comment #2)
> (From update of attachment 164892 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=164892&action=review
> 
> > Source/WebCore/Resources/pagepopups/calendarPicker.js:382
> > -    var elementHeight = this._element.offsetHeight;
> >      this._element.style.width = "auto";
> >      daysAreaElement.style.width = "100%";
> >      daysAreaElement.style.tableLayout = "fixed";
> >      this._element.getElementsByClassName(ClassNames.YearMonthUpper)[0].style.display = "-webkit-box";
> >      this._element.getElementsByClassName(ClassNames.MonthSelectorBox)[0].style.display = "block";
> > +    var elementHeight = this._element.offsetHeight;
> 
> Why do you move elementHeight?
> 
> ChangeLog should explain such reasons of changes.

Removed this change.
Comment 5 Kent Tamura 2012-09-20 22:29:29 PDT 
Comment on attachment 165047 [details]
Patch

ok
Comment 6 WebKit Review Bot 2012-09-21 00:01:59 PDT 
Comment on attachment 165047 [details]
Patch

Clearing flags on attachment: 165047

Committed r129198: <http://trac.webkit.org/changeset/129198>
Comment 7 WebKit Review Bot 2012-09-21 00:02:03 PDT 
All reviewed patches have been landed.  Closing bug.