Bug 97187 - [chromium] Adding the 'google_apis' directory to .gitignore.
Summary: [chromium] Adding the 'google_apis' directory to .gitignore.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike West
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-20 03:08 PDT by Mike West
Modified: 2012-09-20 06:13 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.02 KB, patch)
2012-09-20 03:09 PDT, Mike West
no flags Details | Formatted Diff | Diff
No tabs. (1.02 KB, patch)
2012-09-20 03:30 PDT, Mike West
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike West 2012-09-20 03:08:09 PDT
[chromium] Adding the 'google_apis' directory to .gitignore.
Comment 1 Mike West 2012-09-20 03:09:14 PDT
Created attachment 164875 [details]
Patch
Comment 2 Mike West 2012-09-20 03:10:24 PDT
Hey Jochen! Mind applying a rubber-stamp R+/CQ+ to a trivial patch? :)
Comment 3 WebKit Review Bot 2012-09-20 03:13:46 PDT
Attachment 164875 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/.gitignore', u'Sour..." exit_code: 1
Source/WebKit/chromium/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Mike West 2012-09-20 03:30:36 PDT
Created attachment 164881 [details]
No tabs.
Comment 5 jochen 2012-09-20 06:08:57 PDT
Comment on attachment 164881 [details]
No tabs.

Ok
Comment 6 WebKit Review Bot 2012-09-20 06:13:53 PDT
Comment on attachment 164881 [details]
No tabs.

Clearing flags on attachment: 164881

Committed r129124: <http://trac.webkit.org/changeset/129124>
Comment 7 WebKit Review Bot 2012-09-20 06:13:55 PDT
All reviewed patches have been landed.  Closing bug.