Bug 97166 - REGRESSION(r127727): Can't navigate between months with arrow keys in calendar picker
Summary: REGRESSION(r127727): Can't navigate between months with arrow keys in calenda...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-19 21:53 PDT by Keishi Hattori
Modified: 2012-09-20 01:35 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.55 KB, patch)
2012-09-19 22:46 PDT, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (7.59 KB, patch)
2012-09-19 23:59 PDT, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2012-09-19 21:53:09 PDT 
Can't navigate between months with arrow keys in calendar picker
Comment 1 Keishi Hattori 2012-09-19 22:46:31 PDT 
Created attachment 164842 [details]
Patch
Comment 2 Kent Tamura 2012-09-19 23:00:11 PDT 
Comment on attachment 164842 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164842&action=review

> LayoutTests/fast/forms/date/calendar-picker-key-operations.html:33
> +    shouldBe('selectedDate()', '"1999-12-26"');
> +    eventSender.keyDown('upArrow');
> +    shouldBe('selectedDate()', '"2000-01-02"');

I don't understand this.
1999-12-26 + upArrow isn't 1999-12-19?
Comment 3 Keishi Hattori 2012-09-19 23:06:03 PDT 
Comment on attachment 164842 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164842&action=review

>> LayoutTests/fast/forms/date/calendar-picker-key-operations.html:33
>> +    shouldBe('selectedDate()', '"2000-01-02"');
> 
> I don't understand this.
> 1999-12-26 + upArrow isn't 1999-12-19?

This is moving from 1999-12-26  in the top row of the January calendar to 2000-01-02 in the last row of the December calendar.
Comment 4 Kent Tamura 2012-09-19 23:15:23 PDT 
Comment on attachment 164842 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164842&action=review

>>> LayoutTests/fast/forms/date/calendar-picker-key-operations.html:33
>>> +    shouldBe('selectedDate()', '"2000-01-02"');
>> 
>> I don't understand this.
>> 1999-12-26 + upArrow isn't 1999-12-19?
> 
> This is moving from 1999-12-26  in the top row of the January calendar to 2000-01-02 in the last row of the December calendar.

Oh, I see.

We had better check YearMonthController.year() and month() values in the test, or add comments in the test.
Comment 5 Keishi Hattori 2012-09-19 23:59:56 PDT 
Created attachment 164849 [details]
Patch
Comment 6 Kent Tamura 2012-09-20 01:01:37 PDT 
Comment on attachment 164849 [details]
Patch

ok
Comment 7 WebKit Review Bot 2012-09-20 01:34:58 PDT 
Comment on attachment 164849 [details]
Patch

Clearing flags on attachment: 164849

Committed r129106: <http://trac.webkit.org/changeset/129106>
Comment 8 WebKit Review Bot 2012-09-20 01:35:01 PDT 
All reviewed patches have been landed.  Closing bug.