RESOLVED FIXED 97166
REGRESSION(r127727): Can't navigate between months with arrow keys in calendar picker 
https://bugs.webkit.org/show_bug.cgi?id=97166
Summary REGRESSION(r127727): Can't navigate between months with arrow keys in calenda...
Keishi Hattori
Reported 2012-09-19 21:53:09 PDT
Can't navigate between months with arrow keys in calendar picker
Attachments
Patch (6.55 KB, patch)
2012-09-19 22:46 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (7.59 KB, patch)
2012-09-19 23:59 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2012-09-19 22:46:31 PDT
Created attachment 164842 [details] Patch
Kent Tamura
Comment 2 2012-09-19 23:00:11 PDT
Comment on attachment 164842 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164842&action=review > LayoutTests/fast/forms/date/calendar-picker-key-operations.html:33 > + shouldBe('selectedDate()', '"1999-12-26"'); > + eventSender.keyDown('upArrow'); > + shouldBe('selectedDate()', '"2000-01-02"'); I don't understand this. 1999-12-26 + upArrow isn't 1999-12-19?
Keishi Hattori
Comment 3 2012-09-19 23:06:03 PDT
Comment on attachment 164842 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164842&action=review >> LayoutTests/fast/forms/date/calendar-picker-key-operations.html:33 >> + shouldBe('selectedDate()', '"2000-01-02"'); > > I don't understand this. > 1999-12-26 + upArrow isn't 1999-12-19? This is moving from 1999-12-26 in the top row of the January calendar to 2000-01-02 in the last row of the December calendar.
Kent Tamura
Comment 4 2012-09-19 23:15:23 PDT
Comment on attachment 164842 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164842&action=review >>> LayoutTests/fast/forms/date/calendar-picker-key-operations.html:33 >>> + shouldBe('selectedDate()', '"2000-01-02"'); >> >> I don't understand this. >> 1999-12-26 + upArrow isn't 1999-12-19? > > This is moving from 1999-12-26 in the top row of the January calendar to 2000-01-02 in the last row of the December calendar. Oh, I see. We had better check YearMonthController.year() and month() values in the test, or add comments in the test.
Keishi Hattori
Comment 5 2012-09-19 23:59:56 PDT
Created attachment 164849 [details] Patch
Kent Tamura
Comment 6 2012-09-20 01:01:37 PDT
Comment on attachment 164849 [details] Patch ok
WebKit Review Bot
Comment 7 2012-09-20 01:34:58 PDT
Comment on attachment 164849 [details] Patch Clearing flags on attachment: 164849 Committed r129106: <http://trac.webkit.org/changeset/129106>
WebKit Review Bot
Comment 8 2012-09-20 01:35:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.