RESOLVED WONTFIX 97160
[Refactoring] Extract a code to match attribute selector from SelectorChecker::checkOneSelector 
https://bugs.webkit.org/show_bug.cgi?id=97160
Summary [Refactoring] Extract a code to match attribute selector from SelectorChecker...
Shinya Kawanaka
Reported 2012-09-19 18:50:34 PDT
For preparation of https://bugs.webkit.org/show_bug.cgi?id=96990, we would like to extract a code to match attribute selector. We will reuse the code later.
Attachments
Patch (3.40 KB, patch)
2012-09-19 19:08 PDT, Shinya Kawanaka 		dglazkov: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-09-19 19:08:18 PDT
Created attachment 164823 [details] Patch
Hajime Morrita
Comment 2 2012-09-19 19:09:48 PDT
Comment on attachment 164823 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164823&action=review > Source/WebCore/css/SelectorChecker.cpp:1282 > + if (!anyAttributeMatches(element, static_cast<CSSSelector::Match>(selector->m_match), attr, selector->value(), caseSensitive)) Why not just return here?
Dimitri Glazkov (Google)
Comment 3 2012-09-19 19:49:55 PDT
Can we hold off on this patch until we have a slightly better idea on how content selector matching machinery will look like?
Dimitri Glazkov (Google)
Comment 4 2012-10-02 09:52:44 PDT
Comment on attachment 164823 [details] Patch This is now obsolete. Right?
Hayato Ito
Comment 5 2012-10-04 06:06:25 PDT
(In reply to comment #4) > (From update of attachment 164823 [details]) > This is now obsolete. Right? Seems obsolete.
Note You need to log in before you can comment on or make changes to this bug.