Bug 97152 - update flakiness dashboard after cutover to new test expectations syntax
Summary: update flakiness dashboard after cutover to new test expectations syntax
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-19 17:46 PDT by Dirk Pranke
Modified: 2012-09-19 19:05 PDT (History)
2 users (show)

See Also:

Attachments
Patch (11.44 KB, patch)
2012-09-19 17:47 PDT, Dirk Pranke 		no flags Details | Formatted Diff | Diff
Patch (4.04 KB, patch)
2012-09-19 18:12 PDT, Dirk Pranke 		ojan: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-09-19 17:46:59 PDT 
update flakiness dashboard after cutover to new test expectations syntax
Comment 1 Dirk Pranke 2012-09-19 17:47:20 PDT 
Created attachment 164808 [details]
Patch
Comment 2 Dirk Pranke 2012-09-19 17:58:59 PDT 
Committed r129079: <http://trac.webkit.org/changeset/129079>
Comment 3 Dirk Pranke 2012-09-19 18:12:30 PDT 
Reopening to attach new patch.
Comment 4 Dirk Pranke 2012-09-19 18:12:32 PDT 
Created attachment 164813 [details]
Patch
Comment 5 Ojan Vafai 2012-09-19 18:18:38 PDT 
Comment on attachment 164813 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164813&action=review

Don't you also need to modify processExpectations? I guess that can be a separate patch.

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.js:984
> +    // FIXME: do we still need the INTERNAL_BUG replacements? They're
> +    // broken temporarily.

No. You can just delete this whole function.
Comment 6 Ojan Vafai 2012-09-19 18:19:03 PDT 
OIC. That was the previous patch.