Bug 97140 – nrwt: convert Qt TestExpectations to the new format

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dirk Pranke]

nrwt: convert Qt TestExpectations to the new format

[Dirk Pranke]

Created attachment 164792 [details]
Patch

[WebKit Review Bot]

Attachment 164792 [details] did not pass style-queue:

WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
LayoutTests/platform/qt-mac/TestExpectations:1:  No port uses path LayoutTests/platform/qt-mac/TestExpectations for test_expectations  [test/expectations] [5]
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
LayoutTests/platform/qt-4.8/TestExpectations:1:  No port uses path LayoutTests/platform/qt-4.8/TestExpectations for test_expectations  [test/expectations] [5]
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
LayoutTests/platform/qt-arm/TestExpectations:1:  No port uses path LayoutTests/platform/qt-arm/TestExpectations for test_expectations  [test/expectations] [5]
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
LayoutTests/platform/qt-5.0-wk2/TestExpectations:1:  No port uses path LayoutTests/platform/qt-5.0-wk2/TestExpectations for test_expectations  [test/expectations] [5]
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checkFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
ed out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky.
Total errors found: 4 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dirk Pranke]

Committed r129058: <http://trac.webkit.org/changeset/129058>

[Ojan Vafai]

Comment on attachment 164792 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164792&action=review

> LayoutTests/platform/qt-arm/TestExpectations:6
> +Bug(_qt_slow) fast/workers/worker-multi-startup.html [ Pass Slow ]
> +Bug(_qt_slow) fast/workers/wrapper-map-gc.html [ Pass Slow ]
>  
> -// failing tests
> -BUG_ARM SKIP: css3/flexbox/flex-algorithm.html = FAIL
> -BUG_ARM SKIP: fast/canvas/canvas-fillRect-gradient-shadow.html = FAIL
> -BUG_ARM SKIP: fast/dom/constructed-objects-prototypes.html = FAIL
> -BUG_ARM SKIP: fast/events/constructors/webgl-context-event-constructor.html = FAIL
> -BUG_ARM SKIP: fast/js/constructor-length.html = FAIL
> -BUG_ARM SKIP: fast/js/dfg-inlining-reg-alloc.html = FAIL
> -BUG_ARM SKIP: fast/js/global-constructors.html = FAIL
> -BUG_ARM SKIP: fast/multicol/overflow-content.html = FAIL
> -BUG_ARM SKIP: http/tests/cache/subresource-expiration-1.html = FAIL
> -BUG_ARM SKIP: http/tests/cache/subresource-expiration-2.html = FAIL
> -BUG_ARM SKIP: http/tests/cache/subresource-multiple-instances.html = FAIL
> -BUG_ARM SKIP: svg/dom/path-parser.html = FAIL
> +# failing tests
> +Bug(_arm) css3/flexbox/flex-algorithm.html [ Failure Skip ]

These should be Bug(qt_slow) and Bug(arm)

[Dirk Pranke]

(In reply to comment #4)
> (From update of attachment 164792 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=164792&action=review
> 
> > LayoutTests/platform/qt-arm/TestExpectations:6
> > +Bug(_qt_slow) fast/workers/worker-multi-startup.html [ Pass Slow ]
> > +Bug(_qt_slow) fast/workers/wrapper-map-gc.html [ Pass Slow ]
> >  
> > -// failing tests
> > -BUG_ARM SKIP: css3/flexbox/flex-algorithm.html = FAIL
> > -BUG_ARM SKIP: fast/canvas/canvas-fillRect-gradient-shadow.html = FAIL
> > -BUG_ARM SKIP: fast/dom/constructed-objects-prototypes.html = FAIL
> > -BUG_ARM SKIP: fast/events/constructors/webgl-context-event-constructor.html = FAIL
> > -BUG_ARM SKIP: fast/js/constructor-length.html = FAIL
> > -BUG_ARM SKIP: fast/js/dfg-inlining-reg-alloc.html = FAIL
> > -BUG_ARM SKIP: fast/js/global-constructors.html = FAIL
> > -BUG_ARM SKIP: fast/multicol/overflow-content.html = FAIL
> > -BUG_ARM SKIP: http/tests/cache/subresource-expiration-1.html = FAIL
> > -BUG_ARM SKIP: http/tests/cache/subresource-expiration-2.html = FAIL
> > -BUG_ARM SKIP: http/tests/cache/subresource-multiple-instances.html = FAIL
> > -BUG_ARM SKIP: svg/dom/path-parser.html = FAIL
> > +# failing tests
> > +Bug(_arm) css3/flexbox/flex-algorithm.html [ Failure Skip ]
> 
> These should be Bug(qt_slow) and Bug(arm)

Yeah, the conversion script wasn't smart enough to strip leading underscores. In practice, it's not like it matters since these aren't real bugs, but I will patch things in a follow-up bug.