Bug 97139 - nrwt: convert chromium TestExpectations to the new syntax
Summary: nrwt: convert chromium TestExpectations to the new syntax
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-19 15:45 PDT by Dirk Pranke
Modified: 2015-08-28 16:17 PDT (History)
7 users (show)

See Also:


Attachments
Patch (415.07 KB, patch)
2012-09-19 15:49 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-09-19 15:45:45 PDT
nrwt: convert chromium TestExpectations to the new syntax
Comment 1 Dirk Pranke 2012-09-19 15:49:51 PDT
Created attachment 164790 [details]
Patch
Comment 2 Ryosuke Niwa 2012-09-19 15:53:17 PDT
Comment on attachment 164790 [details]
Patch

rs=me.
Comment 3 Dirk Pranke 2012-09-19 16:00:09 PDT
Committed r129057: <http://trac.webkit.org/changeset/129057>
Comment 4 Ojan Vafai 2012-09-19 16:00:09 PDT
Comment on attachment 164790 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164790&action=review

> Tools/Scripts/convert-test-expectations:7
> +

For thoroughness sake, maybe put a FIXME to delete this file once all the conversions are done?

> LayoutTests/platform/chromium/TestExpectations:154
> +webkit.org/b/68610 fast/dom/MicroData

Now that I see this in practice, I think it's pretty confusing to not have [ Skip ] indicating that the test is skipped. WDYT?

> LayoutTests/platform/chromium/TestExpectations:157
> +crbug.com/103939 http/tests/appcache/wrong-content-type.html [ Failure Skip ]

Sorry if my memory is foggy here. Didn't we decide to now allow an expectation type if the test is skipped?

> LayoutTests/platform/chromium/TestExpectations:229
> +dom/xhtml/level2/html/HTMLDocument17.xhtml [ Failure Skip WontFix ]

In the end we want this to just be [ WontFix ], right? Will we just need to do another pass over the file once we support WontFix without Skip or other listed expectations?
Comment 5 Ojan Vafai 2012-09-19 16:00:44 PDT
Comment on attachment 164790 [details]
Patch

Whoops. Didn't mean to overwrite the review flag.
Comment 6 Dirk Pranke 2012-09-19 16:05:59 PDT
(In reply to comment #3)
> (From update of attachment 164790 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=164790&action=review
> 
> > Tools/Scripts/convert-test-expectations:7
> > +
> 
> For thoroughness sake, maybe put a FIXME to delete this file once all the conversions are done?
> 

Well, I already landed this, but yeah, I'll add on shortly.

> > LayoutTests/platform/chromium/TestExpectations:154
> > +webkit.org/b/68610 fast/dom/MicroData
> 
> Now that I see this in practice, I think it's pretty confusing to not have [ Skip ] indicating that the test is skipped. WDYT?
>

I'm inclined to agree. 

> > LayoutTests/platform/chromium/TestExpectations:157
> > +crbug.com/103939 http/tests/appcache/wrong-content-type.html [ Failure Skip ]
> 
> Sorry if my memory is foggy here. Didn't we decide to now allow an expectation type if the test is skipped?
>

I also have a very foggy memory; I think you're right but I forgot to implement that. I'll file a bug.

 
> > LayoutTests/platform/chromium/TestExpectations:229
> > +dom/xhtml/level2/html/HTMLDocument17.xhtml [ Failure Skip WontFix ]
> 
> In the end we want this to just be [ WontFix ], right? Will we just need to do another pass over the file once we support WontFix without Skip or other listed expectations?

Right, on both counts. I'll roll that into the Skip bug.
Comment 7 Dirk Pranke 2012-09-19 16:23:03 PDT
Turns out the new chromium TestExpectations file didn't actually get committed, due to a merge conflict. 

I landed it separately in http://trac.webkit.org/changeset/129063 .
Comment 8 Tim Horton 2015-08-28 16:17:04 PDT
Removed the script in http://trac.webkit.org/changeset/189132