Bug 97116 - [Chromium] Move notifyJSOutOfMemory out of PlatformSupport
Summary: [Chromium] Move notifyJSOutOfMemory out of PlatformSupport
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
URL:
Keywords:
Depends on:
Blocks: 82948
  Show dependency tree / graph
 
Reported: 2012-09-19 10:15 PDT by Mark Pilgrim (Google)
Modified: 2012-09-19 10:53 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.32 KB, patch)
2012-09-19 10:15 PDT, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2012-09-19 10:15:00 PDT 
[Chromium] Move notifyJSOutOfMemory out of PlatformSupport
Comment 1 Mark Pilgrim (Google) 2012-09-19 10:15:45 PDT 
Created attachment 164751 [details]
Patch
Comment 2 Mark Pilgrim (Google) 2012-09-19 10:17:19 PDT 
Routing call from WebCore/bindings/v8/V8Binding through FrameLoaderClient instead of PlatformSupport.
Comment 3 Adam Barth 2012-09-19 10:19:57 PDT 
Comment on attachment 164751 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164751&action=review

> Source/WebKit/chromium/src/FrameLoaderClientImpl.h:64
> +    // Script in the page tried to allocate too much memory.

I'd skip this comment.
Comment 4 WebKit Review Bot 2012-09-19 10:53:25 PDT 
Comment on attachment 164751 [details]
Patch

Clearing flags on attachment: 164751

Committed r129020: <http://trac.webkit.org/changeset/129020>
Comment 5 WebKit Review Bot 2012-09-19 10:53:29 PDT 
All reviewed patches have been landed.  Closing bug.