Bug 97099 - [BlackBerry] Add function playerId() in class PageClientBlackBerry
Summary: [BlackBerry] Add function playerId() in class PageClientBlackBerry
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Dong
Depends on:
Reported: 2012-09-19 05:18 PDT by Jonathan Dong
Modified: 2012-09-19 08:53 PDT (History)
7 users (show)

See Also:

Patch (4.68 KB, patch)
2012-09-19 05:33 PDT, Jonathan Dong
no flags Details | Formatted Diff | Diff
Patch (4.68 KB, patch)
2012-09-19 08:17 PDT, Jonathan Dong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Dong 2012-09-19 05:18:45 PDT
RIM PR: 210858

For network stream classes, they get the playerId() from class
FrameLoaderClientBlackBerry::playerId(), which gets the id from
WebCore::WebPageClient::getInstanceId(). There's also a special stream class:
MediaSSLHandlerStream which is responsible for ssl verification of mmr engine,
and this stream class's object is created inside a MMRPlayer and can only
access to the PageClientBlackBerry.

So I'm thinking of adding a new member function playerId() for
PageClientBlackBerry, by doing this we can provide playerId() to
MediaSSLHandlerStream directly and to other network streams via
FrameLoaderClientBlackBerry as usual. Then we can upstream our media ssl
handling codes for RIM PR 116205.
Comment 1 Jonathan Dong 2012-09-19 05:33:08 PDT
Created attachment 164722 [details]
Comment 2 Yong Li 2012-09-19 07:17:19 PDT
Comment on attachment 164722 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=164722&action=review

otherwise LGTM

> Source/WebKit/blackberry/Api/WebPage_p.h:182
> +    virtual int playerId() const;

according to WebKit style or existing code, we should name it playerID() rather than playerId.
Comment 3 Jonathan Dong 2012-09-19 08:17:20 PDT
Created attachment 164741 [details]
Comment 4 WebKit Review Bot 2012-09-19 08:53:53 PDT
Comment on attachment 164741 [details]

Clearing flags on attachment: 164741

Committed r129010: <http://trac.webkit.org/changeset/129010>
Comment 5 WebKit Review Bot 2012-09-19 08:53:56 PDT
All reviewed patches have been landed.  Closing bug.