Bug 97094 – [EFL][WK2] Same page navigation does not update view URI

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Chris Dumez]

In case of same page navigation, the view URI is currently not updated because we don't handle didSameDocumentNavigationForFrame callback in WKPageLoaderClient.

[Chris Dumez]

Created attachment 164712 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 164712 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164712&action=review

> Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:224
> +struct URIChangedData {
> +    URIChangedData(const char* uri, double timeoutSeconds, Ecore_Task_Cb callback)
> +        : expectedURI(uri)
> +        , done(false)
> +        , timer(0)
> +        , didTimeOut(false)
> +    {
> +        if (timeoutSeconds >= 0)
> +            timer = ecore_timer_add(timeoutSeconds, callback, this);
> +    }
> +

Maybe it is about time to make a base class?

> Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:237
> +static void onURIChanged(void* userData, Evas_Object* webView, void* eventInfo)

Why are we callign it URI when everyone(?) else calls it URL in webkit?

[Chris Dumez]

Comment on attachment 164712 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164712&action=review

>> Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:224
>> +
> 
> Maybe it is about time to make a base class?

Sure, I can clean this up.

>> Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:237
>> +static void onURIChanged(void* userData, Evas_Object* webView, void* eventInfo)
> 
> Why are we callign it URI when everyone(?) else calls it URL in webkit?

Probably out of consistency with EFL WebKit1. Considering the ewk_view method is called ewk_view_uri_get(), I think using URI here is consistent.

[Chris Dumez]

Created attachment 164845 [details]
Patch

Refactor the callback data in Test framework.

[Kenneth Rohde Christiansen]

Comment on attachment 164845 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164845&action=review

This looks so much better

> Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:174
> +    if (strcmp(ewk_view_title_get(webView), data->expectedValue().data()))

why not just value() ?

[WebKit Review Bot]

Comment on attachment 164845 [details]
Patch

Clearing flags on attachment: 164845

Committed r129099: <http://trac.webkit.org/changeset/129099>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.