WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
97092
[GTK] REGRESSION(
r128907
): it broke several WebKit2 API tests
https://bugs.webkit.org/show_bug.cgi?id=97092
Summary
[GTK] REGRESSION(r128907): it broke several WebKit2 API tests
Carlos Garcia Campos
Reported
2012-09-19 03:04:03 PDT
The problem is in RedirectedXCompositeWindow implementation. Every WebView creates a RedirectedXCompositeWindow of size 1,1. At the end of the constructor resize and resizeLater function are called: resize(size); resizeLater(); // Force update of the usable area. resize always schedules a resizeLater call because m_usableSize is uninitialized (0, 0) and is always smaller than size (1, 1). The first resizeLater, called right after resize() resets the m_pendingResizeSourceId. If the window is destroyed before the second resizeLater is called (called from the main loop), the destructor won't remove the source, because it has been reset by the first resizeLater and after the objects is freed, the second resizeLater will be called by the main loop with an already freed RedirectedXCompositeWindow. This happens often in unit tests where web view are created and destroyed quickly. Instead of calling resizeLater from the constructor to initialize m_usableSize, we could just initialize it to the given size.
Attachments
Patch
(1.86 KB, patch)
2012-09-19 03:07 PDT
,
Carlos Garcia Campos
mrobinson
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1
2012-09-19 03:07:30 PDT
Created
attachment 164704
[details]
Patch
Martin Robinson
Comment 2
2012-09-19 06:10:40 PDT
Comment on
attachment 164704
[details]
Patch Thanks!
Carlos Garcia Campos
Comment 3
2012-09-19 07:00:33 PDT
Committed
r128996
: <
http://trac.webkit.org/changeset/128996
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug